summary refs log tree commit diff stats
path: root/lib/filter.h
diff options
context:
space:
mode:
authorKelly Rauchenberger <fefferburbia@gmail.com>2017-02-06 20:58:37 -0500
committerKelly Rauchenberger <fefferburbia@gmail.com>2017-02-06 20:58:37 -0500
commitf1f67e62cebb4144f0599196263cd93b41fa972e (patch)
tree5d0f8fceeec63f47fb85846f5568bcb36f4a975f /lib/filter.h
parent6cc23ba387d0813b801ba094709673a61bac889c (diff)
downloadverbly-f1f67e62cebb4144f0599196263cd93b41fa972e.tar.gz
verbly-f1f67e62cebb4144f0599196263cd93b41fa972e.tar.bz2
verbly-f1f67e62cebb4144f0599196263cd93b41fa972e.zip
Made pronunciation::rhymes join dynamic
This involved adding a new type of filter; one that compares (currently
only equality and inequality) a field with another field located in an
enclosing join context.

In the process, it was discovered that simplifying the lemma::forms join
field earlier actually made some queries return inaccurate results
because the inflection of the form was being ignored and anything in the
lemma would be used because of the inner join. Because the existing
condition join did not allow for the condition field to be on the from
side of the join, two things were done: a condition version of
joinThrough was made, and lemma was finally eliminated as a top-level
object, replaced instead with a condition join between word and form
through lemmas_forms.

Queries are also now grouped by the first select field (assumed to be
the primary ID) of the top table, in order to eliminate duplicates
created by inner joins, so that there is a uniform distribution between
results for random queries.

Created a database index on pronunciations(rhyme) which decreases query
time for rhyming filters. The new database version is
backwards-compatible because no data or structure changed.
Diffstat (limited to 'lib/filter.h')
-rw-r--r--lib/filter.h8
1 files changed, 7 insertions, 1 deletions
diff --git a/lib/filter.h b/lib/filter.h index dcadf95..a12a822 100644 --- a/lib/filter.h +++ b/lib/filter.h
@@ -34,7 +34,9 @@ namespace verbly {
34 matches, 34 matches,
35 does_not_match, 35 does_not_match,
36 hierarchally_matches, 36 hierarchally_matches,
37 does_not_hierarchally_match 37 does_not_hierarchally_match,
38 field_equals,
39 field_does_not_equal
38 }; 40 };
39 41
40 // Copy and move constructors 42 // Copy and move constructors
@@ -72,6 +74,7 @@ namespace verbly {
72 filter(field filterField, comparison filterType, bool filterValue); 74 filter(field filterField, comparison filterType, bool filterValue);
73 filter(field filterField, comparison filterType); 75 filter(field filterField, comparison filterType);
74 filter(field joinOn, comparison filterType, filter joinCondition); 76 filter(field joinOn, comparison filterType, filter joinCondition);
77 filter(field filterField, comparison filterType, field compareField);
75 78
76 field getField() const; 79 field getField() const;
77 80
@@ -85,6 +88,8 @@ namespace verbly {
85 88
86 bool getBooleanArgument() const; 89 bool getBooleanArgument() const;
87 90
91 field getCompareField() const;
92
88 // Group 93 // Group
89 94
90 explicit filter(bool orlogic); 95 explicit filter(bool orlogic);
@@ -129,6 +134,7 @@ namespace verbly {
129 std::string stringValue; 134 std::string stringValue;
130 int intValue; 135 int intValue;
131 bool boolValue; 136 bool boolValue;
137 field compareField;
132 }; 138 };
133 } singleton_; 139 } singleton_;
134 struct { 140 struct {