Don't create useless connections

Connections that can't be used unless you already have access to the other side (e.g. being on the "wrong side" of a vanilla door) are useless because they never increase access. This change turns these into oneway connections. This has helped with ER failures significantly, reducing the fail rate from about 14% to about 3%.

1 files changed, 6 insertions, 0 deletions

@@ -132,6 +132,12 @@ def create_regions(world: "Lingo2World"):
         reqs.simplify()
         reqs.remove_room(from_region)
 
+        if to_region in reqs.rooms:
+            # This connection can't ever increase access because you're required to have access to the other side in
+            # order for it to be usable. We will just not create the connection at all, in order to help GER figure out
+            # what regions are dead ends.
+            continue
+
         connection = Entrance(world.player, connection_name, regions[from_region])
         connection.access_rule = make_location_lambda(reqs, world, regions)