Lingo: Various item/location renames (#2746)

## What is this fixing or adding?
- Roof MASTERY panels are now technically in individual regions with more descriptive names, so they can be displayed better on the tracker.
- Orange Tower Seventh Floor - Mastery has been renamed to simply Mastery.
- The Optimistic is its own region now.
- The misnamed CEILING in Room Room has been fixed.
- The misnamed CHEESE in Challenge Room has been fixed.
- The misnamed SOUND in Outside the Bold has been fixed.
- "The Bearer - Shortcut to The Bold" is now "The Bearer - Entrance".
- HUB ROOM - NEAR, FAR and the Warts Straw and Leaf Feel Areas have now been semantically combined into the "Symmetry Room". They are still logically three separate regions.
- The FACTS chain in Challenge Room has been reindexed, and the full chain panel is now indicated as such.
- The Room Room floors have been reindexed.
- Panels in The Observant are now named by their questions, not answers.
- Added a (1) subscript to several panels in Orange Tower Fourth Floor, Outside The Initiated, and The Seeker.

The validate_config.rb script has also been updated to check that all items and locations have an ID.

This change should not impact generation logic at all. It is just changing item and location names.

1 files changed, 28 insertions, 1 deletions

@@ -8,7 +8,8 @@ require 'set'
 require 'yaml'
 
 configpath = ARGV[0]
-mappath = ARGV[1]
+idspath = ARGV[1]
+mappath = ARGV[2]
 
 panels = Set["Countdown Panels/Panel_1234567890_wanderlust"]
 doors = Set["Naps Room Doors/Door_hider_new1", "Tower Room Area Doors/Door_wanderer_entrance"]
@@ -46,6 +47,8 @@ painting_directives = Set["id", "enter_only", "exit_only", "orientation", "requi
 
 non_counting = 0
 
+ids = YAML.load_file(idspath)
+
 config = YAML.load_file(configpath)
 config.each do |room_name, room|
   configured_rooms.add(room_name)
@@ -162,6 +165,10 @@ config.each do |room_name, room|
     unless bad_subdirectives.empty? then
       puts "#{room_name} - #{panel_name} :::: Panel has the following invalid subdirectives: #{bad_subdirectives.join(", ")}"
     end
+
+    unless ids.include?("panels") and ids["panels"].include?(room_name) and ids["panels"][room_name].include?(panel_name)
+      puts "#{room_name} - #{panel_name} :::: Panel is missing a location ID"
+    end
   end
 
   (room["doors"] || {}).each do |door_name, door|
@@ -229,6 +236,18 @@ config.each do |room_name, room|
     unless bad_subdirectives.empty? then
       puts "#{room_name} - #{door_name} :::: Door has the following invalid subdirectives: #{bad_subdirectives.join(", ")}"
     end
+
+    unless door["skip_item"] or door["event"]
+      unless ids.include?("doors") and ids["doors"].include?(room_name) and ids["doors"][room_name].include?(door_name) and ids["doors"][room_name][door_name].include?("item")
+        puts "#{room_name} - #{door_name} :::: Door is missing an item ID"
+      end
+    end
+
+    unless door["skip_location"] or door["event"]
+      unless ids.include?("doors") and ids["doors"].include?(room_name) and ids["doors"][room_name].include?(door_name) and ids["doors"][room_name][door_name].include?("location")
+        puts "#{room_name} - #{door_name} :::: Door is missing a location ID"
+      end
+    end
   end
 
   (room["paintings"] || []).each do |painting|
@@ -281,6 +300,10 @@ config.each do |room_name, room|
         mentioned_doors.add("#{room_name} - #{door}")
       end
     end
+
+    unless ids.include?("progression") and ids["progression"].include?(progression_name)
+      puts "#{room_name} - #{progression_name} :::: Progression is missing an item ID"
+    end
   end
 end
 
@@ -303,6 +326,10 @@ door_groups.each do |group,num|
   if num == 1 then
     puts "Door group \"#{group}\" only has one door in it"
   end
+
+  unless ids.include?("door_groups") and ids["door_groups"].include?(group)
+    puts "#{group} :::: Door group is missing an item ID"
+  end
 end
 
 slashed_rooms = configured_rooms.select do |room|