9 files changed, 40 insertions, 67 deletions

@@ -29,8 +29,8 @@
 #include "tracker_state.h"
 
 constexpr int AP_MAJOR = 0;
-constexpr int AP_MINOR = 4;
-constexpr int AP_REVISION = 5;
+constexpr int AP_MINOR = 6;
+constexpr int AP_REVISION = 1;
 
 constexpr const char* CERT_STORE_PATH = "cacert.pem";
 constexpr int ITEM_HANDLING = 7;  // <- all
@@ -503,8 +503,9 @@ struct APState {
                            : kSUNWARP_ACCESS_NORMAL;
       sunwarp_shuffle = slot_data.contains("shuffle_sunwarps") &&
                         slot_data["shuffle_sunwarps"].get<int>() == 1;
-      postgame_shuffle = slot_data.contains("shuffle_postgame") &&
-                         slot_data["shuffle_postgame"].get<int>() == 1;
+      postgame_shuffle = slot_data.contains("shuffle_postgame")
+                             ? (slot_data["shuffle_postgame"].get<int>() == 1)
+                             : true;
 
       if (painting_shuffle && slot_data.contains("painting_entrance_to_exit")) {
         painting_mapping.clear();
@@ -50,11 +50,8 @@ void AreaPopup::ResetIndicators() {
   for (int section_id = 0; section_id < map_area.locations.size();
        section_id++) {
     const Location& location = map_area.locations.at(section_id);
-    if (IsLocationPostgame(location.ap_location_id)) {
-      continue;
-    }
-
-    if (!AP_IsLocationVisible(location.classification) &&
+    if ((!AP_IsLocationVisible(location.classification) ||
+         IsLocationPostgame(location.ap_location_id)) &&
         !(location.hunt &&
           GetTrackerConfig().visible_panels == TrackerConfig::kHUNT_PANELS) &&
         !(location.single_panel &&
@@ -29,7 +29,6 @@ struct GameData {
   std::map<std::string, int> painting_by_id_;
 
   std::vector<int> door_definition_order_;
-  std::vector<int> room_definition_order_;
 
   std::map<std::string, int> room_by_painting_;
   std::map<int, int> room_by_sunwarp_;
@@ -92,7 +91,6 @@ struct GameData {
 
     for (const auto &room_it : lingo_config) {
       int room_id = AddOrGetRoom(room_it.first.as<std::string>());
-      room_definition_order_.push_back(room_id);
 
       for (const auto &entrance_it : room_it.second["entrances"]) {
         int from_room_id = AddOrGetRoom(entrance_it.first.as<std::string>());
@@ -780,31 +778,6 @@ struct GameData {
       }
     }
 
-    // As a workaround for a generator bug in 0.5.1, we are going to remove the
-    // panel door requirement on panels that are defined earlier in the file than
-    // the panel door is. This results in logic that matches the generator, even
-    // if it is not true to how the game should work. This will be reverted once
-    // the logic bug is fixed and released.
-    // See: https://github.com/ArchipelagoMW/Archipelago/pull/4342
-    for (Panel& panel : panels_) {
-      if (panel.panel_door == -1) {
-        continue;
-      }
-      const PanelDoor &panel_door = panel_doors_[panel.panel_door];
-      for (int room_id : room_definition_order_) {
-        if (room_id == panel_door.room) {
-          // The panel door was defined first (or at the same time as the panel),
-          // so we're good.
-          break;
-        } else if (room_id == panel.room) {
-          // The panel was defined first, so we have to pretend the panel door is
-          // not required for this panel.
-          panel.panel_door = -1;
-          break;
-        }
-      }
-    }
-
     // Report errors.
     for (const std::string &area : malconfigured_areas_) {
       TrackerLog(fmt::format("Area data not found for: {}", area));
@@ -937,7 +910,7 @@ struct GameData {
     if (!panel_doors_by_id_.count(full_name)) {
       int panel_door_id = panel_doors_.size();
       panel_doors_by_id_[full_name] = panel_door_id;
-      panel_doors_.push_back({.room = AddOrGetRoom(room)});
+      panel_doors_.push_back({});
     }
 
     return panel_doors_by_id_[full_name];
@@ -86,7 +86,6 @@ struct Door {
 };
 
 struct PanelDoor {
-  int room;
   int ap_item_id = -1;
   int group_ap_item_id = -1;
   std::vector<ProgressiveRequirement> progressives;
@@ -10,7 +10,7 @@
 
 class TrackerApp : public wxApp {
  public:
-  virtual bool OnInit() {
+  virtual bool OnInit() override {
     GetTrackerConfig().Load();
 
     TrackerFrame *frame = new TrackerFrame();
@@ -55,15 +55,13 @@ void TrackerPanel::UpdateIndicators(bool reset) {
     for (AreaIndicator &area : areas_) {
       const MapArea &map_area = GD_GetMapArea(area.area_id);
 
-      if (IsAreaPostgame(area.area_id)) {
-        area.active = false;
-      } else if (!AP_IsLocationVisible(map_area.classification) &&
-                 !(map_area.hunt && GetTrackerConfig().visible_panels ==
-                                        TrackerConfig::kHUNT_PANELS) &&
-                 !(map_area.has_single_panel &&
-                   GetTrackerConfig().visible_panels ==
-                       TrackerConfig::kALL_PANELS) &&
-                 !(AP_IsPaintingShuffle() && !map_area.paintings.empty())) {
+      if ((!AP_IsLocationVisible(map_area.classification) ||
+           IsAreaPostgame(area.area_id)) &&
+          !(map_area.hunt &&
+            GetTrackerConfig().visible_panels == TrackerConfig::kHUNT_PANELS) &&
+          !(map_area.has_single_panel &&
+            GetTrackerConfig().visible_panels == TrackerConfig::kALL_PANELS) &&
+          !(AP_IsPaintingShuffle() && !map_area.paintings.empty())) {
         area.active = false;
       } else {
         area.active = true;
@@ -233,11 +231,10 @@ void TrackerPanel::Redraw() {
     bool has_unreachable_unchecked = false;
     for (const Location &section : map_area.locations) {
       bool has_unchecked = false;
-      if (IsLocationPostgame(section.ap_location_id)) {
-        // Nope.
-      } else if (IsLocationWinCondition(section)) {
+      if (IsLocationWinCondition(section)) {
         has_unchecked = !AP_HasReachedGoal();
-      } else if (AP_IsLocationVisible(section.classification)) {
+      } else if (AP_IsLocationVisible(section.classification) &&
+                 !IsLocationPostgame(section.ap_location_id)) {
         has_unchecked = !AP_HasCheckedGameLocation(section.ap_location_id);
       } else if ((section.hunt && GetTrackerConfig().visible_panels ==
                                       TrackerConfig::kHUNT_PANELS) ||
@@ -36,7 +36,7 @@ std::string CalculateStringSha256(const wxString& data) {
 
   char output[65] = {0};
   for (int i = 0; i < SHA256_DIGEST_LENGTH; i++) {
-    sprintf(output + (i * 2), "%02x", hash[i]);
+    snprintf(output + (i * 2), 3, "%02x", hash[i]);
   }
 
   return std::string(output);
@@ -172,26 +172,33 @@ void Updater::InstallUpdate(std::string url, std::string checksum,
     return;
   }
 
-  package_path_.clear();
-  package_path_.resize(L_tmpnam + 1);
-  tmpnam_s(package_path_.data(), L_tmpnam);
+  bool download_issue = false;
 
-  {
-    wxFileOutputStream writeOut(package_path_);
+  wxFileName package_path;
+  package_path.AssignTempFileName("");
+
+  if (!package_path.IsOk()) {
+    download_issue = true;
+  } else {
+    wxFileOutputStream writeOut(package_path.GetFullPath());
     wxString fileData = packageRequest.GetResponse().AsString();
     writeOut.WriteAll(fileData.c_str(), fileData.length());
 
     std::string downloadedChecksum = CalculateStringSha256(fileData);
     if (downloadedChecksum != checksum) {
-      if (wxMessageBox("There was an issue downloading the update. Would you "
-                       "like to manually download it instead?",
-                       "Error", wxYES_NO | wxICON_ERROR) == wxID_YES) {
-        wxLaunchDefaultBrowser(kChangelogUrl);
-      }
-      return;
+      download_issue = true;
     }
   }
 
+  if (download_issue) {
+    if (wxMessageBox("There was an issue downloading the update. Would you "
+                     "like to manually download it instead?",
+                     "Error", wxYES_NO | wxICON_ERROR) == wxID_YES) {
+      wxLaunchDefaultBrowser(kChangelogUrl);
+    }
+    return;
+  }
+
   std::filesystem::path newArea = GetExecutableDirectory();
   std::filesystem::path oldArea = newArea / "old";
   std::set<std::filesystem::path> folders;
@@ -241,7 +248,7 @@ void Updater::InstallUpdate(std::string url, std::string checksum,
     }
   }
 
-  wxFileInputStream fileInputStream(package_path_);
+  wxFileInputStream fileInputStream(package_path.GetFullPath());
   wxZipInputStream zipStream(fileInputStream);
   std::unique_ptr<wxZipEntry> zipEntry;
   while ((zipEntry = std::unique_ptr<wxZipEntry>(zipStream.GetNextEntry())) !=
@@ -41,7 +41,6 @@ class Updater : public wxEvtHandler {
 
   wxFrame* parent_;
   UpdateState update_state_ = UpdateState::GetVersionInvisible;
-  std::string package_path_;
 };
 
 #endif /* end of include guard: UPDATER_H_809E7381 */
@@ -36,6 +36,6 @@ struct Version {
   }
 };
 
-constexpr const Version kTrackerVersion = Version(1, 0, 0);
+constexpr const Version kTrackerVersion = Version(2, 0, 2);
 
 #endif /* end of include guard: VERSION_H_C757E53C */
\ No newline at end of file