Use wx functions to get a temporary filename

This is safer and more portable than the previous solution (tmpnam_s).

2 files changed, 19 insertions, 13 deletions

@@ -172,26 +172,33 @@ void Updater::InstallUpdate(std::string url, std::string checksum,
     return;
   }
 
-  package_path_.clear();
-  package_path_.resize(L_tmpnam + 1);
-  tmpnam_s(package_path_.data(), L_tmpnam);
+  bool download_issue = false;
 
-  {
-    wxFileOutputStream writeOut(package_path_);
+  wxFileName package_path;
+  package_path.AssignTempFileName("");
+
+  if (!package_path.IsOk()) {
+    download_issue = true;
+  } else {
+    wxFileOutputStream writeOut(package_path.GetPath());
     wxString fileData = packageRequest.GetResponse().AsString();
     writeOut.WriteAll(fileData.c_str(), fileData.length());
 
     std::string downloadedChecksum = CalculateStringSha256(fileData);
     if (downloadedChecksum != checksum) {
-      if (wxMessageBox("There was an issue downloading the update. Would you "
-                       "like to manually download it instead?",
-                       "Error", wxYES_NO | wxICON_ERROR) == wxID_YES) {
-        wxLaunchDefaultBrowser(kChangelogUrl);
-      }
-      return;
+      download_issue = true;
     }
   }
 
+  if (download_issue) {
+    if (wxMessageBox("There was an issue downloading the update. Would you "
+                     "like to manually download it instead?",
+                     "Error", wxYES_NO | wxICON_ERROR) == wxID_YES) {
+      wxLaunchDefaultBrowser(kChangelogUrl);
+    }
+    return;
+  }
+
   std::filesystem::path newArea = GetExecutableDirectory();
   std::filesystem::path oldArea = newArea / "old";
   std::set<std::filesystem::path> folders;
@@ -241,7 +248,7 @@ void Updater::InstallUpdate(std::string url, std::string checksum,
     }
   }
 
-  wxFileInputStream fileInputStream(package_path_);
+  wxFileInputStream fileInputStream(package_path.GetPath());
   wxZipInputStream zipStream(fileInputStream);
   std::unique_ptr<wxZipEntry> zipEntry;
   while ((zipEntry = std::unique_ptr<wxZipEntry>(zipStream.GetNextEntry())) !=
@@ -41,7 +41,6 @@ class Updater : public wxEvtHandler {
 
   wxFrame* parent_;
   UpdateState update_state_ = UpdateState::GetVersionInvisible;
-  std::string package_path_;
 };
 
 #endif /* end of include guard: UPDATER_H_809E7381 */