about summary refs log tree commit diff stats
diff options
context:
space:
mode:
authorKelly Rauchenberger <fefferburbia@gmail.com>2017-12-17 14:44:38 -0500
committerKelly Rauchenberger <fefferburbia@gmail.com>2017-12-17 14:44:38 -0500
commit1d4b88e0bfe162419bf9466341ccec5f1e5656da (patch)
treeef54986affca40fc6e23830d0c1a1980774e61b7
parentdf906121dd862c0f704e44f28ee079158c431c41 (diff)
downloadlibtwittercpp-1d4b88e0bfe162419bf9466341ccec5f1e5656da.tar.gz
libtwittercpp-1d4b88e0bfe162419bf9466341ccec5f1e5656da.tar.bz2
libtwittercpp-1d4b88e0bfe162419bf9466341ccec5f1e5656da.zip
Updated curlcpp (important bug fixes)
This update fixes the underlying issue behind an infinite-stalling bug
that has been around since differencebot was written. The four bots that
download images from ImageNet (difference, advice, grunge, capital) had
the same small logic error whereby the catch block, written to handle the
situation when an image had failed to download, incorrectly took the
exception by value rather than by const reference. While inefficient,
this should not have caused any problems, but curlcpp, which the four
bots all use through libtwitter++'s dependence on it, had a bug in the
copy constructor of the curl_exception object which could cause a
deadlock situation. This went unnoticed for a while, despite the four
bots having serious downtime issues. When this was discovered, the bots
were patched so that the relevant catch block took the exception by
const reference. While this fixed things, it is also prudent to update
curlcpp to the newest version in which this bug has been fixed.

refs JosephP91/curlcpp#100
m---------vendor/curlcpp0
1 files changed, 0 insertions, 0 deletions
diff --git a/vendor/curlcpp b/vendor/curlcpp
Subproject 687be1c252dce098f488ca8a46d847dac497231 Subproject 11c4979d323f2e12a466bb768b66569e5f9a7ea