diff options
| author | Kelly Rauchenberger <fefferburbia@gmail.com> | 2008-08-16 18:32:17 +0000 |
|---|---|---|
| committer | Kelly Rauchenberger <fefferburbia@gmail.com> | 2008-08-16 18:32:17 +0000 |
| commit | 4db316a432ce3d4fb280f64b64d3f1d0f3295b39 (patch) | |
| tree | 8e16e1543344b177b04aee780780c85271ca55eb | |
| parent | 2d998db45226ca7efd39ec6e04b9891ccf129d4f (diff) | |
| download | instadisc-4db316a432ce3d4fb280f64b64d3f1d0f3295b39.tar.gz instadisc-4db316a432ce3d4fb280f64b64d3f1d0f3295b39.tar.bz2 instadisc-4db316a432ce3d4fb280f64b64d3f1d0f3295b39.zip | |
General: Upped default verIDBufferSize
Because of the increase in possible Verification ID values, it will be even less likely to have a repeat, so the number that are buffered is being increased. A test was run to find repeats if 10000 numbers were generated between 1 and 2147483647 and a repeat was found only once at the 8500th number, the rest of the tests (20 others) passed successfully. Refs #37
| -rw-r--r-- | central/trunk/install.php | 2 | ||||
| -rw-r--r-- | client/trunk/src/com/fourisland/instadisc/AdvancedSettingsForm.java | 4 | ||||
| -rw-r--r-- | client/trunk/src/com/fourisland/instadisc/FirstRun/Step2.java | 2 |
3 files changed, 4 insertions, 4 deletions
| diff --git a/central/trunk/install.php b/central/trunk/install.php index b2b1396..c056431 100644 --- a/central/trunk/install.php +++ b/central/trunk/install.php | |||
| @@ -193,7 +193,7 @@ if (!isset($_GET['submit'])) | |||
| 193 | $sql[5] = "INSERT INTO config (name,value) VALUES (\"siteName\",\"" . mysql_real_escape_string($_POST['siteName']) . "\")"; | 193 | $sql[5] = "INSERT INTO config (name,value) VALUES (\"siteName\",\"" . mysql_real_escape_string($_POST['siteName']) . "\")"; |
| 194 | $sql[6] = "INSERT INTO config (name,value) VALUES (\"xmlrpcURL\",\"" . mysql_real_escape_string($_POST['xmlrpcURL']) . "\")"; | 194 | $sql[6] = "INSERT INTO config (name,value) VALUES (\"xmlrpcURL\",\"" . mysql_real_escape_string($_POST['xmlrpcURL']) . "\")"; |
| 195 | $sql[7] = "INSERT INTO config (name,value) VALUES (\"owner\",\"" . mysql_real_escape_string($_POST['adminUser']) . "\")"; | 195 | $sql[7] = "INSERT INTO config (name,value) VALUES (\"owner\",\"" . mysql_real_escape_string($_POST['adminUser']) . "\")"; |
| 196 | $sql[8] = "INSERT INTO config (name,value) VALUES (\"verIDBufferSize\",\"100\")"; | 196 | $sql[8] = "INSERT INTO config (name,value) VALUES (\"verIDBufferSize\",\"10000\")"; |
| 197 | $sql[9] = "INSERT INTO config (name,value) VALUES (\"softwareVersion\",\"" . $softwareVersion . "\")"; | 197 | $sql[9] = "INSERT INTO config (name,value) VALUES (\"softwareVersion\",\"" . $softwareVersion . "\")"; |
| 198 | $sql[10] = "INSERT INTO config (name,value) VALUES (\"databaseVersion\",\"1\")"; | 198 | $sql[10] = "INSERT INTO config (name,value) VALUES (\"databaseVersion\",\"1\")"; |
| 199 | $sql[11] = "INSERT INTO users (username, password, email, ip) VALUES (\"" . mysql_real_escape_string($_POST['adminUser']) . "\",\"" . mysql_real_escape_string(md5($_POST['adminPass'])) . "\",\"" . mysql_real_escape_string($_POST['adminEmail']) . "\",\"" . mysql_real_escape_string($_SERVER['REMOTE_ADDR']) . "\")"; | 199 | $sql[11] = "INSERT INTO users (username, password, email, ip) VALUES (\"" . mysql_real_escape_string($_POST['adminUser']) . "\",\"" . mysql_real_escape_string(md5($_POST['adminPass'])) . "\",\"" . mysql_real_escape_string($_POST['adminEmail']) . "\",\"" . mysql_real_escape_string($_SERVER['REMOTE_ADDR']) . "\")"; |
| diff --git a/client/trunk/src/com/fourisland/instadisc/AdvancedSettingsForm.java b/client/trunk/src/com/fourisland/instadisc/AdvancedSettingsForm.java index 14469ea..597aca8 100644 --- a/client/trunk/src/com/fourisland/instadisc/AdvancedSettingsForm.java +++ b/client/trunk/src/com/fourisland/instadisc/AdvancedSettingsForm.java | |||
| @@ -22,14 +22,14 @@ public class AdvancedSettingsForm extends javax.swing.JDialog { | |||
| 22 | 22 | ||
| 23 | SpinnerNumberModel sm = new SpinnerNumberModel(); | 23 | SpinnerNumberModel sm = new SpinnerNumberModel(); |
| 24 | sm.setValue(Integer.decode(Wrapper.getConfig("itemBufferSize"))); | 24 | sm.setValue(Integer.decode(Wrapper.getConfig("itemBufferSize"))); |
| 25 | sm.setMaximum(100); | 25 | sm.setMaximum(1000); |
| 26 | sm.setMinimum(1); | 26 | sm.setMinimum(1); |
| 27 | sm.setStepSize(1); | 27 | sm.setStepSize(1); |
| 28 | jSpinner1.setModel(sm); | 28 | jSpinner1.setModel(sm); |
| 29 | 29 | ||
| 30 | SpinnerNumberModel sm2 = new SpinnerNumberModel(); | 30 | SpinnerNumberModel sm2 = new SpinnerNumberModel(); |
| 31 | sm2.setValue(Integer.decode(Wrapper.getConfig("verIDBufferSize"))); | 31 | sm2.setValue(Integer.decode(Wrapper.getConfig("verIDBufferSize"))); |
| 32 | sm2.setMaximum(10000); | 32 | sm2.setMaximum(100000); |
| 33 | sm2.setMinimum(1); | 33 | sm2.setMinimum(1); |
| 34 | sm2.setStepSize(1); | 34 | sm2.setStepSize(1); |
| 35 | jSpinner2.setModel(sm2); | 35 | jSpinner2.setModel(sm2); |
| diff --git a/client/trunk/src/com/fourisland/instadisc/FirstRun/Step2.java b/client/trunk/src/com/fourisland/instadisc/FirstRun/Step2.java index 0a8287b..7133f6f 100644 --- a/client/trunk/src/com/fourisland/instadisc/FirstRun/Step2.java +++ b/client/trunk/src/com/fourisland/instadisc/FirstRun/Step2.java | |||
| @@ -166,7 +166,7 @@ public class Step2 extends javax.swing.JDialog { | |||
| 166 | Wrapper.setConfig("password", password); | 166 | Wrapper.setConfig("password", password); |
| 167 | Wrapper.setConfig("centralServerURL", jTextField3.getText()); | 167 | Wrapper.setConfig("centralServerURL", jTextField3.getText()); |
| 168 | Wrapper.setConfig("itemBufferSize", "10"); | 168 | Wrapper.setConfig("itemBufferSize", "10"); |
| 169 | Wrapper.setConfig("verIDBufferSize", "100"); | 169 | Wrapper.setConfig("verIDBufferSize", "10000"); |
| 170 | Wrapper.setConfig("nextFilterID", "0"); | 170 | Wrapper.setConfig("nextFilterID", "0"); |
| 171 | Wrapper.setConfig("ipCheckValue", "1"); | 171 | Wrapper.setConfig("ipCheckValue", "1"); |
| 172 | Wrapper.setConfig("ipCheckUnit", "day"); | 172 | Wrapper.setConfig("ipCheckUnit", "day"); |
