Extended GameCharacters from ArrayList

4 files changed, 37 insertions, 47 deletions

@@ -8,7 +8,6 @@ package com.fourisland.fourpuzzle;
 import com.fourisland.fourpuzzle.util.ObjectLoader;
 import javax.sound.midi.MidiSystem;
 import javax.sound.midi.Sequencer;
-import javax.sound.midi.Track;
 
 /**
  *
@@ -46,7 +45,7 @@ public class Audio {
     }
     
     public static void playMusic(String file, boolean loop, float speed) throws Exception
-    {   
+    {
         seq.setSequence(ObjectLoader.getMusic(file));
 
         if (loop)
@@ -12,45 +12,42 @@ import java.util.ArrayList;
  *
  * @author hatkirby
  */
-public class GameCharacters implements Cloneable {
+public class GameCharacters extends ArrayList<GameCharacter>
+{
+    private GameCharacters() {}
     
-    private GameCharacters()
+    private static GameCharacters INSTANCE = new GameCharacters();
+    public static GameCharacters getDefaultParty()
     {
+        return INSTANCE;
     }
-    
-    public static GameCharacters INSTANCE = new GameCharacters();
 
-    public void add(GameCharacter e)
+    public static GameCharacters createParty()
     {
-        characters.add(e);
+        GameCharacters temp = new GameCharacters();
+        temp.addAll(INSTANCE);
+        
+        return temp;
     }
 
     public GameCharacter getLeader() throws Exception
     {
-        int i = 0;
-        for (i=0;i<characters.size();i++)
+        for (GameCharacter chara : this)
         {
-            if (characters.get(i).isInParty())
+            if (chara.isInParty())
             {
-                return characters.get(i);
+                return chara;
             }
         }
         
         Game.setGameState(new GameOverGameState());
-        throw new NoCharactersInPartyException();
-    }
-    public GameCharacters newInstance() throws CloneNotSupportedException
-    {
-        return (GameCharacters) clone();
+        return null;
     }
-
-    private ArrayList<GameCharacter> characters = new ArrayList<GameCharacter>();
     
     public boolean exists(String heroName) {
-        int i=0;
-        for (i=0;i<characters.size();i++)
+        for (GameCharacter chara : this)
         {
-            if (characters.get(i).getName().equals(heroName))
+            if (chara.getName().equals(heroName))
             {
                 return true;
             }
@@ -59,17 +56,12 @@ public class GameCharacters implements Cloneable {
         return false;
     }
 
-    public GameCharacter get(Integer get) {
-        return characters.get(get);
-    }
-
     public GameCharacter get(String heroName) throws NullPointerException {
-        int i=0;
-        for (i=0;i<characters.size();i++)
+        for (GameCharacter chara : this)
         {
-            if (characters.get(i).getName().equals(heroName))
+            if (chara.getName().equals(heroName))
             {
-                return characters.get(i);
+                return chara;
             }
         }
         
@@ -26,7 +26,7 @@ public class SaveFile implements Serializable {
     public SaveFile() throws CloneNotSupportedException
     {
         switches = new HashMap<String, Boolean>();
-        party = GameCharacters.INSTANCE.newInstance();
+        party = GameCharacters.createParty();
         variables = new HashMap<String, Integer>();
         currentMap = new String();
         hero = new HeroEvent();
@@ -75,27 +75,26 @@ public abstract class Map {
             return true;
         }
         
-        int i=0;
-        for (i=0;i<events.size();i++)
+        for (LayerEvent ev : events)
         {
-            if (events.get(i).getLayer() == Layer.Middle)
+            if (ev.getLayer() == Layer.Middle)
             {
-                if ((events.get(i).getLocation().y == (y - 1)) && (events.get(i).getLocation().x == x) && (toMove == Direction.North))
+                if ((ev.getLocation().y == (y - 1)) && (ev.getLocation().x == x) && (toMove == Direction.North))
                 {
                     return true;
                 }
                 
-                if ((events.get(i).getLocation().x == (x - 1)) && (events.get(i).getLocation().y == y) && (toMove == Direction.West))
+                if ((ev.getLocation().x == (x - 1)) && (ev.getLocation().y == y) && (toMove == Direction.West))
                 {
                     return true;
                 }
                 
-                if ((events.get(i).getLocation().y == (y + 1)) && (events.get(i).getLocation().x == x) && (toMove == Direction.South))
+                if ((ev.getLocation().y == (y + 1)) && (ev.getLocation().x == x) && (toMove == Direction.South))
                 {
                     return true;
                 }
                 
-                if ((events.get(i).getLocation().x == (x + 1)) && (events.get(i).getLocation().y == y) && (toMove == Direction.East))
+                if ((ev.getLocation().x == (x + 1)) && (ev.getLocation().y == y) && (toMove == Direction.East))
                 {
                     return true;
                 }
@@ -124,32 +123,32 @@ public abstract class Map {
         
         ChipSet cSI = ChipSet.getChipSet(chipSet);
         HashMap<Integer,ChipSetData> cSID = cSI.getChipSetData();
-        for (i=0;i<getMapData().size();i++)
+        for (HashMap<Integer,Integer> mapArea : getMapData())
         {
-            if ((toMove == Direction.North) && (!cSID.get(mapData.get(i).get(x+((y-1)*getSize().width))).isEnableSouth()))
+            if ((toMove == Direction.North) && (!cSID.get(mapArea.get(x+((y-1)*getSize().width))).isEnableSouth()))
             {
                 return true;
-            } else if ((toMove == Direction.West) && (!cSID.get(mapData.get(i).get(x-1+(y*getSize().width))).isEnableEast()))
+            } else if ((toMove == Direction.West) && (!cSID.get(mapArea.get(x-1+(y*getSize().width))).isEnableEast()))
             {
                 return true;
-            } else if ((toMove == Direction.South) && (!cSID.get(mapData.get(i).get(x+((y+1)*getSize().width))).isEnableNorth()))
+            } else if ((toMove == Direction.South) && (!cSID.get(mapArea.get(x+((y+1)*getSize().width))).isEnableNorth()))
             {
                 return true;
-            } else if ((toMove == Direction.East) && (!cSID.get(mapData.get(i).get(x+1+(y*getSize().width))).isEnableWest()))
+            } else if ((toMove == Direction.East) && (!cSID.get(mapArea.get(x+1+(y*getSize().width))).isEnableWest()))
             {
                 return true;
             }
 
-            if ((toMove == Direction.North) && (!cSID.get(mapData.get(i).get(x+(y*getSize().width))).isEnableNorth()))
+            if ((toMove == Direction.North) && (!cSID.get(mapArea.get(x+(y*getSize().width))).isEnableNorth()))
             {
                 return true;
-            } else if ((toMove == Direction.West) && (!cSID.get(mapData.get(i).get(x+(y*getSize().width))).isEnableWest()))
+            } else if ((toMove == Direction.West) && (!cSID.get(mapArea.get(x+(y*getSize().width))).isEnableWest()))
             {
                 return true;
-            } else if ((toMove == Direction.South) && (!cSID.get(mapData.get(i).get(x+(y*getSize().width))).isEnableSouth()))
+            } else if ((toMove == Direction.South) && (!cSID.get(mapArea.get(x+(y*getSize().width))).isEnableSouth()))
             {
                 return true;
-            } else if ((toMove == Direction.East) && (!cSID.get(mapData.get(i).get(x+(y*getSize().width))).isEnableEast()))
+            } else if ((toMove == Direction.East) && (!cSID.get(mapArea.get(x+(y*getSize().width))).isEnableEast()))
             {
                 return true;
             }