Fix RNG -- this will break seeds, though.

1 files changed, 4 insertions, 3 deletions

@@ -1,7 +1,7 @@
 #include <chrono>
 #include "Random.h"
 
-int Random::s_seed = static_cast<int>(time(nullptr)); // Seed from the time in milliseconds
+uint32_t Random::s_seed = static_cast<int>(time(nullptr)); // Seed from the time in milliseconds
 
 void Random::SetSeed(int seed) {
     s_seed = seed;
@@ -9,6 +9,7 @@ void Random::SetSeed(int seed) {
 
 // Returns a random integer in [min, max]
 int Random::RandInt(int min, int max) {
-    s_seed = (214013 * s_seed + 2531011) % 2147483648;
-    return (s_seed % (max - min + 1)) + min;
+    s_seed = (214013 * s_seed + 2531011); // Implicit unsigned integer overflow
+    int32_t maskedSeed = ((s_seed >> 16) & 0x7fff); // Only use bits 16-30
+    return (maskedSeed % (max - min + 1)) + min;
 }