From 30cd66e1521bc760df45908adb2f7d3ba6683900 Mon Sep 17 00:00:00 2001
From: Kelly Rauchenberger <fefferburbia@gmail.com>
Date: Sun, 14 Jan 2018 13:06:18 -0500
Subject: Cached a Pokémon's latest revision
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit

This removes the need to use a GROUP or DISTINCT in eager-loading Pokémon on the front page. It duplicates data, but provisions are in place to keep the cache up-to-date. When a Pokémon record is updated, it is required that its cache points to the current revision. When a revision is created, it updates the Pokémon's cache to point to it, because a new revision will always be the most recent one, and it is impossible to reorder revisions.

This does not affect the number of queries used on the front page (see #1).

refs #4
---
 app/models/pokeviewer/pokemon.rb  | 16 +++++++++++++++-
 app/models/pokeviewer/revision.rb |  9 +++++++++
 2 files changed, 24 insertions(+), 1 deletion(-)

(limited to 'app/models')

diff --git a/app/models/pokeviewer/pokemon.rb b/app/models/pokeviewer/pokemon.rb
index 012abab..77ee89a 100644
--- a/app/models/pokeviewer/pokemon.rb
+++ b/app/models/pokeviewer/pokemon.rb
@@ -4,7 +4,9 @@ module Pokeviewer
     extend ActiveModel::Naming
 
     has_many :revisions, -> { order "sequential_id ASC" }, dependent: :destroy
-    has_one :current, -> { order "sequential_id DESC" }, class_name: "Revision"
+
+    belongs_to :current, class_name: "Revision", optional: true
+    validate :current_is_cached
 
     belongs_to :trainer, optional: true
 
@@ -149,5 +151,17 @@ module Pokeviewer
       def uuid_is_constant
         errors.add(:uuid, "can't be changed") if self.uuid_changed?
       end
+
+      def current_is_cached
+        if self.revisions.empty?
+          unless self.current_id.nil?
+            errors.add(:current, "must be null when there are no revisions")
+          end
+        else
+          unless self.current_id = self.revisions.last.id
+            errors.add(:current, "is not up-to-date")
+          end
+        end
+      end
   end
 end
diff --git a/app/models/pokeviewer/revision.rb b/app/models/pokeviewer/revision.rb
index 64b0e99..e5ad1dd 100644
--- a/app/models/pokeviewer/revision.rb
+++ b/app/models/pokeviewer/revision.rb
@@ -17,6 +17,8 @@ module Pokeviewer
     belongs_to :pokemon
     acts_as_sequenced scope: :pokemon_id
 
+    after_create :cache_pokemon_current
+
     belongs_to :species
 
     validates :nickname, presence: true
@@ -483,5 +485,12 @@ module Pokeviewer
 
       result
     end
+
+    private
+
+      def cache_pokemon_current
+        self.pokemon.current_id = self.id
+        self.pokemon.save!
+      end
   end
 end
-- 
cgit 1.4.1