Replaced GROUP clause in front page query with DISTINCT

Apparently the choice of row to be returned with a GROUP that uses fields outside of ones that are functionally dependent on the GROUP fields is arbitrary, as per https://dev.mysql.com/doc/refman/5.7/en/group-by-handling.html

1 files changed, 3 insertions, 3 deletions

@@ -3,12 +3,12 @@ require_dependency "pokeviewer/application_controller"
 module Pokeviewer
   class PokemonController < ApplicationController
     def index
-      pokemon = Pokemon.joins(:current).
-        order("trainer_id IS NULL DESC").
+      pokemon = Pokemon.order("trainer_id IS NULL DESC").
         order(trainer_id: :asc).
         order(box: :asc).
         order(slot: :asc).
-        group("pokeviewer_pokemon.uuid").
+        select(:uuid).distinct.
+        order("pokeviewer_revisions.sequential_id DESC").
         includes(:current).
         chunk do |p|
           if p.trainer_id.nil?