about summary refs log tree commit diff stats
path: root/tools
diff options
context:
space:
mode:
Diffstat (limited to 'tools')
-rw-r--r--tools/assign_ids/main.cpp193
-rw-r--r--tools/datapacker/container.cpp34
-rw-r--r--tools/datapacker/container.h6
-rw-r--r--tools/datapacker/main.cpp95
-rw-r--r--tools/util/godot_scene.cpp6
-rw-r--r--tools/util/ids_yaml_format.cpp39
-rw-r--r--tools/validator/human_processor.cpp153
-rw-r--r--tools/validator/structs.h26
-rw-r--r--tools/validator/validator.cpp172
9 files changed, 664 insertions, 60 deletions
diff --git a/tools/assign_ids/main.cpp b/tools/assign_ids/main.cpp index e65e5e4..3e16f78 100644 --- a/tools/assign_ids/main.cpp +++ b/tools/assign_ids/main.cpp
@@ -2,6 +2,7 @@
2#include <google/protobuf/text_format.h> 2#include <google/protobuf/text_format.h>
3 3
4#include <cstdint> 4#include <cstdint>
5#include <filesystem>
5#include <fstream> 6#include <fstream>
6#include <iostream> 7#include <iostream>
7#include <map> 8#include <map>
@@ -40,6 +41,10 @@ class AssignIds {
40 ReadIds(ids_path); 41 ReadIds(ids_path);
41 42
42 ProcessMaps(datadir_path); 43 ProcessMaps(datadir_path);
44 ProcessSpecialIds();
45 ProcessProgressivesFile(datadir_path / "progressives.txtpb");
46 ProcessDoorGroupsFile(datadir_path / "door_groups.txtpb");
47 ProcessGlobalMetadataFile(datadir_path / "metadata.txtpb");
43 48
44 WriteIds(ids_path); 49 WriteIds(ids_path);
45 50
@@ -54,50 +59,26 @@ class AssignIds {
54 id_mappings_ = ReadIdsFromYaml(path.string()); 59 id_mappings_ = ReadIdsFromYaml(path.string());
55 60
56 for (const auto& [_, map] : id_mappings_.maps()) { 61 for (const auto& [_, map] : id_mappings_.maps()) {
57 for (const auto& [_, id] : map.doors()) { 62 UpdateNextId(map.doors());
58 if (id > next_id_) {
59 next_id_ = id;
60 }
61 }
62 63
63 for (const auto& [_, room] : map.rooms()) { 64 for (const auto& [_, room] : map.rooms()) {
64 for (const auto& [_, id] : room.panels()) { 65 UpdateNextId(room.panels());
65 if (id > next_id_) { 66 UpdateNextId(room.masteries());
66 next_id_ = id; 67 UpdateNextId(room.keyholders());
67 }
68 }
69
70 for (const auto& [_, id] : room.masteries()) {
71 if (id > next_id_) {
72 next_id_ = id;
73 }
74 }
75 }
76 }
77
78 for (const auto& [_, id] : id_mappings_.special()) {
79 if (id > next_id_) {
80 next_id_ = id;
81 }
82 }
83
84 for (const auto& [_, id] : id_mappings_.letters()) {
85 if (id > next_id_) {
86 next_id_ = id;
87 } 68 }
88 } 69 }
89 70
90 for (const auto& [_, id] : id_mappings_.endings()) { 71 UpdateNextId(id_mappings_.special());
91 if (id > next_id_) { 72 UpdateNextId(id_mappings_.letters());
92 next_id_ = id; 73 UpdateNextId(id_mappings_.endings());
93 } 74 UpdateNextId(id_mappings_.progressives());
94 } 75 UpdateNextId(id_mappings_.door_groups());
95 76
96 next_id_++; 77 next_id_++;
97 } 78 }
98 79
99 void WriteIds(std::filesystem::path path) { 80 void WriteIds(std::filesystem::path path) {
100 WriteIdsAsYaml(id_mappings_, path.string()); 81 WriteIdsAsYaml(output_, path.string());
101 } 82 }
102 83
103 void ProcessMaps(std::filesystem::path path) { 84 void ProcessMaps(std::filesystem::path path) {
@@ -134,14 +115,18 @@ class AssignIds {
134 return; 115 return;
135 } 116 }
136 117
118 auto& maps = *output_.mutable_maps();
119 auto& doors = *maps[current_map_name].mutable_doors();
120
137 if (!id_mappings_.maps().contains(current_map_name) || 121 if (!id_mappings_.maps().contains(current_map_name) ||
138 !id_mappings_.maps() 122 !id_mappings_.maps()
139 .at(current_map_name) 123 .at(current_map_name)
140 .doors() 124 .doors()
141 .contains(h_door.name())) { 125 .contains(h_door.name())) {
142 auto& maps = *id_mappings_.mutable_maps();
143 auto& doors = *maps[current_map_name].mutable_doors();
144 doors[h_door.name()] = next_id_++; 126 doors[h_door.name()] = next_id_++;
127 } else {
128 doors[h_door.name()] =
129 id_mappings_.maps().at(current_map_name).doors().at(h_door.name());
145 } 130 }
146 } 131 }
147 132
@@ -156,6 +141,10 @@ class AssignIds {
156 void ProcessRoom(const HumanRoom& h_room, 141 void ProcessRoom(const HumanRoom& h_room,
157 const std::string& current_map_name) { 142 const std::string& current_map_name) {
158 for (const HumanPanel& h_panel : h_room.panels()) { 143 for (const HumanPanel& h_panel : h_room.panels()) {
144 auto& maps = *output_.mutable_maps();
145 auto& rooms = *maps[current_map_name].mutable_rooms();
146 auto& panels = *rooms[h_room.name()].mutable_panels();
147
159 if (!id_mappings_.maps().contains(current_map_name) || 148 if (!id_mappings_.maps().contains(current_map_name) ||
160 !id_mappings_.maps() 149 !id_mappings_.maps()
161 .at(current_map_name) 150 .at(current_map_name)
@@ -167,23 +156,33 @@ class AssignIds {
167 .at(h_room.name()) 156 .at(h_room.name())
168 .panels() 157 .panels()
169 .contains(h_panel.name())) { 158 .contains(h_panel.name())) {
170 auto& maps = *id_mappings_.mutable_maps();
171 auto& rooms = *maps[current_map_name].mutable_rooms();
172 auto& panels = *rooms[h_room.name()].mutable_panels();
173 panels[h_panel.name()] = next_id_++; 159 panels[h_panel.name()] = next_id_++;
160 } else {
161 panels[h_panel.name()] = id_mappings_.maps()
162 .at(current_map_name)
163 .rooms()
164 .at(h_room.name())
165 .panels()
166 .at(h_panel.name());
174 } 167 }
175 } 168 }
176 169
177 for (const HumanLetter& h_letter : h_room.letters()) { 170 for (const HumanLetter& h_letter : h_room.letters()) {
178 std::string lettername = GetLetterName(h_letter.key(), h_letter.level2()); 171 std::string lettername = GetLetterName(h_letter.key(), h_letter.level2());
179 172
173 auto& letters = *output_.mutable_letters();
180 if (!id_mappings_.letters().contains(lettername)) { 174 if (!id_mappings_.letters().contains(lettername)) {
181 auto& letters = *id_mappings_.mutable_letters();
182 letters[lettername] = next_id_++; 175 letters[lettername] = next_id_++;
176 } else {
177 letters[lettername] = id_mappings_.letters().at(lettername);
183 } 178 }
184 } 179 }
185 180
186 for (const HumanMastery& h_mastery : h_room.masteries()) { 181 for (const HumanMastery& h_mastery : h_room.masteries()) {
182 auto& maps = *output_.mutable_maps();
183 auto& rooms = *maps[current_map_name].mutable_rooms();
184 auto& masteries = *rooms[h_room.name()].mutable_masteries();
185
187 if (!id_mappings_.maps().contains(current_map_name) || 186 if (!id_mappings_.maps().contains(current_map_name) ||
188 !id_mappings_.maps() 187 !id_mappings_.maps()
189 .at(current_map_name) 188 .at(current_map_name)
@@ -195,27 +194,133 @@ class AssignIds {
195 .at(h_room.name()) 194 .at(h_room.name())
196 .masteries() 195 .masteries()
197 .contains(h_mastery.name())) { 196 .contains(h_mastery.name())) {
198 auto& maps = *id_mappings_.mutable_maps();
199 auto& rooms = *maps[current_map_name].mutable_rooms();
200 auto& masteries = *rooms[h_room.name()].mutable_masteries();
201 masteries[h_mastery.name()] = next_id_++; 197 masteries[h_mastery.name()] = next_id_++;
198 } else {
199 masteries[h_mastery.name()] = id_mappings_.maps()
200 .at(current_map_name)
201 .rooms()
202 .at(h_room.name())
203 .masteries()
204 .at(h_mastery.name());
202 } 205 }
203 } 206 }
204 207
205 for (const HumanEnding& h_ending : h_room.endings()) { 208 for (const HumanEnding& h_ending : h_room.endings()) {
209 auto& endings = *output_.mutable_endings();
210
206 if (!id_mappings_.endings().contains(h_ending.name())) { 211 if (!id_mappings_.endings().contains(h_ending.name())) {
207 auto& endings = *id_mappings_.mutable_endings();
208 endings[h_ending.name()] = next_id_++; 212 endings[h_ending.name()] = next_id_++;
213 } else {
214 endings[h_ending.name()] = id_mappings_.endings().at(h_ending.name());
215 }
216 }
217
218 for (const HumanKeyholder& h_keyholder : h_room.keyholders()) {
219 if (!h_keyholder.has_key()) {
220 continue;
221 }
222
223 auto& maps = *output_.mutable_maps();
224 auto& rooms = *maps[current_map_name].mutable_rooms();
225 auto& keyholders = *rooms[h_room.name()].mutable_keyholders();
226
227 if (!id_mappings_.maps().contains(current_map_name) ||
228 !id_mappings_.maps()
229 .at(current_map_name)
230 .rooms()
231 .contains(h_room.name()) ||
232 !id_mappings_.maps()
233 .at(current_map_name)
234 .rooms()
235 .at(h_room.name())
236 .keyholders()
237 .contains(h_keyholder.name())) {
238 keyholders[h_keyholder.name()] = next_id_++;
239 } else {
240 keyholders[h_keyholder.name()] = id_mappings_.maps()
241 .at(current_map_name)
242 .rooms()
243 .at(h_room.name())
244 .keyholders()
245 .at(h_keyholder.name());
246 }
247 }
248 }
249
250 void ProcessSpecialIds() {
251 auto& specials = *output_.mutable_special();
252
253 for (const auto& [special_name, ap_id] : id_mappings_.special()) {
254 specials[special_name] = ap_id;
255 }
256 }
257
258 void ProcessProgressivesFile(std::filesystem::path path) {
259 if (!std::filesystem::exists(path)) {
260 return;
261 }
262
263 auto h_progs = ReadMessageFromFile<HumanProgressives>(path.string());
264 auto& progs = *output_.mutable_progressives();
265
266 for (const HumanProgressive& h_prog : h_progs.progressives()) {
267 if (!id_mappings_.progressives().contains(h_prog.name())) {
268 progs[h_prog.name()] = next_id_++;
269 } else {
270 progs[h_prog.name()] = id_mappings_.progressives().at(h_prog.name());
271 }
272 }
273 }
274
275 void ProcessDoorGroupsFile(std::filesystem::path path) {
276 if (!std::filesystem::exists(path)) {
277 return;
278 }
279
280 auto h_groups = ReadMessageFromFile<HumanDoorGroups>(path.string());
281 auto& groups = *output_.mutable_door_groups();
282
283 for (const HumanDoorGroup& h_group : h_groups.door_groups()) {
284 if (!id_mappings_.door_groups().contains(h_group.name())) {
285 groups[h_group.name()] = next_id_++;
286 } else {
287 groups[h_group.name()] = id_mappings_.door_groups().at(h_group.name());
288 }
289 }
290 }
291
292 void ProcessGlobalMetadataFile(std::filesystem::path path) {
293 if (!std::filesystem::exists(path)) {
294 return;
295 }
296
297 auto h_metadata = ReadMessageFromFile<HumanGlobalMetadata>(path.string());
298 auto& specials = *output_.mutable_special();
299
300 for (const std::string& h_special : h_metadata.special_names()) {
301 if (!id_mappings_.special().contains(h_special)) {
302 specials[h_special] = next_id_++;
303 } else {
304 specials[h_special] = id_mappings_.special().at(h_special);
209 } 305 }
210 } 306 }
211 } 307 }
212 308
213 private: 309 private:
310 void UpdateNextId(const google::protobuf::Map<std::string, uint64_t>& ids) {
311 for (const auto& [_, id] : ids) {
312 if (id > next_id_) {
313 next_id_ = id;
314 }
315 }
316 }
317
214 std::string mapdir_; 318 std::string mapdir_;
215 319
216 uint64_t next_id_ = 1; 320 uint64_t next_id_ = 1;
217 321
218 IdMappings id_mappings_; 322 IdMappings id_mappings_;
323 IdMappings output_;
219}; 324};
220 325
221} // namespace 326} // namespace
diff --git a/tools/datapacker/container.cpp b/tools/datapacker/container.cpp index 2c68552..4a656b3 100644 --- a/tools/datapacker/container.cpp +++ b/tools/datapacker/container.cpp
@@ -331,6 +331,40 @@ uint64_t Container::FindOrAddDoor(std::optional<std::string> map_name,
331 } 331 }
332} 332}
333 333
334uint64_t Container::FindOrAddProgressive(std::string prog_name) {
335 auto it = progressive_id_by_name_.find(prog_name);
336
337 if (it == progressive_id_by_name_.end()) {
338 uint64_t new_id = all_objects_.progressives_size();
339 Progressive* progressive = all_objects_.add_progressives();
340 progressive->set_id(new_id);
341 progressive->set_name(prog_name);
342
343 progressive_id_by_name_[prog_name] = new_id;
344
345 return new_id;
346 } else {
347 return it->second;
348 }
349}
350
351uint64_t Container::FindOrAddDoorGroup(std::string group_name) {
352 auto it = door_group_id_by_name_.find(group_name);
353
354 if (it == door_group_id_by_name_.end()) {
355 uint64_t new_id = all_objects_.door_groups_size();
356 DoorGroup* door_group = all_objects_.add_door_groups();
357 door_group->set_id(new_id);
358 door_group->set_name(group_name);
359
360 door_group_id_by_name_[group_name] = new_id;
361
362 return new_id;
363 } else {
364 return it->second;
365 }
366}
367
334void Container::AddConnection(const Connection& connection) { 368void Container::AddConnection(const Connection& connection) {
335 *all_objects_.add_connections() = connection; 369 *all_objects_.add_connections() = connection;
336} 370}
diff --git a/tools/datapacker/container.h b/tools/datapacker/container.h index 68f5875..bc02ba4 100644 --- a/tools/datapacker/container.h +++ b/tools/datapacker/container.h
@@ -60,6 +60,10 @@ class Container {
60 60
61 void AddConnection(const Connection& connection); 61 void AddConnection(const Connection& connection);
62 62
63 uint64_t FindOrAddProgressive(std::string prog_name);
64
65 uint64_t FindOrAddDoorGroup(std::string group_name);
66
63 AllObjects& all_objects() { return all_objects_; } 67 AllObjects& all_objects() { return all_objects_; }
64 68
65 private: 69 private:
@@ -82,6 +86,8 @@ class Container {
82 std::map<std::string, std::map<std::string, uint64_t>> 86 std::map<std::string, std::map<std::string, uint64_t>>
83 door_id_by_map_door_names_; 87 door_id_by_map_door_names_;
84 std::map<std::string, uint64_t> ending_id_by_name_; 88 std::map<std::string, uint64_t> ending_id_by_name_;
89 std::map<std::string, uint64_t> progressive_id_by_name_;
90 std::map<std::string, uint64_t> door_group_id_by_name_;
85}; 91};
86 92
87} // namespace com::fourisland::lingo2_archipelago 93} // namespace com::fourisland::lingo2_archipelago
diff --git a/tools/datapacker/main.cpp b/tools/datapacker/main.cpp index 4923fce..c13a4df 100644 --- a/tools/datapacker/main.cpp +++ b/tools/datapacker/main.cpp
@@ -43,6 +43,9 @@ class DataPacker {
43 43
44 ProcessConnectionsFile(datadir_path / "connections.txtpb", std::nullopt); 44 ProcessConnectionsFile(datadir_path / "connections.txtpb", std::nullopt);
45 ProcessMaps(datadir_path); 45 ProcessMaps(datadir_path);
46 ProcessProgressivesFile(datadir_path / "progressives.txtpb");
47 ProcessDoorGroupsFile(datadir_path / "door_groups.txtpb");
48 ProcessGlobalMetadataFile(datadir_path / "metadata.txtpb");
46 ProcessIdsFile(datadir_path / "ids.yaml"); 49 ProcessIdsFile(datadir_path / "ids.yaml");
47 50
48 { 51 {
@@ -104,7 +107,7 @@ class DataPacker {
104 container_.FindOrAddRoom(current_map_name, h_room.name(), std::nullopt); 107 container_.FindOrAddRoom(current_map_name, h_room.name(), std::nullopt);
105 Room& room = *container_.all_objects().mutable_rooms(room_id); 108 Room& room = *container_.all_objects().mutable_rooms(room_id);
106 109
107 //room.set_display_name(h_room.display_name()); 110 // room.set_display_name(h_room.display_name());
108 111
109 if (h_room.has_panel_display_name()) { 112 if (h_room.has_panel_display_name()) {
110 room.set_panel_display_name(h_room.panel_display_name()); 113 room.set_panel_display_name(h_room.panel_display_name());
@@ -292,6 +295,10 @@ class DataPacker {
292 295
293 keyholder.set_path(h_keyholder.path()); 296 keyholder.set_path(h_keyholder.path());
294 297
298 if (h_keyholder.has_key()) {
299 keyholder.set_key(h_keyholder.key());
300 }
301
295 return keyholder_id; 302 return keyholder_id;
296 } 303 }
297 304
@@ -339,8 +346,8 @@ class DataPacker {
339 h_door.receivers().begin(), h_door.receivers().end(), 346 h_door.receivers().begin(), h_door.receivers().end(),
340 google::protobuf::RepeatedFieldBackInserter(door.mutable_receivers())); 347 google::protobuf::RepeatedFieldBackInserter(door.mutable_receivers()));
341 std::copy( 348 std::copy(
342 h_door.switches().begin(), h_door.switches().end(), 349 h_door.senders().begin(), h_door.senders().end(),
343 google::protobuf::RepeatedFieldBackInserter(door.mutable_switches())); 350 google::protobuf::RepeatedFieldBackInserter(door.mutable_senders()));
344 351
345 for (const PaintingIdentifier& pi : h_door.move_paintings()) { 352 for (const PaintingIdentifier& pi : h_door.move_paintings()) {
346 std::optional<std::string> map_name = 353 std::optional<std::string> map_name =
@@ -388,7 +395,7 @@ class DataPacker {
388 door.add_doors( 395 door.add_doors(
389 container_.FindOrAddDoor(map_name, di.name(), current_map_name)); 396 container_.FindOrAddDoor(map_name, di.name(), current_map_name));
390 } 397 }
391 398
392 for (const std::string& ending_name : h_door.endings()) { 399 for (const std::string& ending_name : h_door.endings()) {
393 door.add_endings(container_.FindOrAddEnding(ending_name)); 400 door.add_endings(container_.FindOrAddEnding(ending_name));
394 } 401 }
@@ -461,6 +468,11 @@ class DataPacker {
461 r_connection.set_required_door(door_id); 468 r_connection.set_required_door(door_id);
462 } 469 }
463 470
471 if (human_connection.has_roof_access()) {
472 f_connection.set_roof_access(human_connection.roof_access());
473 r_connection.set_roof_access(human_connection.roof_access());
474 }
475
464 container_.AddConnection(f_connection); 476 container_.AddConnection(f_connection);
465 if (!human_connection.oneway()) { 477 if (!human_connection.oneway()) {
466 container_.AddConnection(r_connection); 478 container_.AddConnection(r_connection);
@@ -544,6 +556,63 @@ class DataPacker {
544 } 556 }
545 } 557 }
546 558
559 void ProcessProgressivesFile(std::filesystem::path path) {
560 if (!std::filesystem::exists(path)) {
561 return;
562 }
563
564 auto h_progs = ReadMessageFromFile<HumanProgressives>(path.string());
565
566 for (const HumanProgressive& h_prog : h_progs.progressives()) {
567 ProcessProgressive(h_prog);
568 }
569 }
570
571 void ProcessProgressive(const HumanProgressive& h_prog) {
572 uint64_t prog_id = container_.FindOrAddProgressive(h_prog.name());
573 Progressive& prog = *container_.all_objects().mutable_progressives(prog_id);
574
575 for (const DoorIdentifier& di : h_prog.doors()) {
576 uint64_t door_id =
577 container_.FindOrAddDoor(di.map(), di.name(), std::nullopt);
578 prog.add_doors(door_id);
579 }
580 }
581
582 void ProcessDoorGroupsFile(std::filesystem::path path) {
583 if (!std::filesystem::exists(path)) {
584 return;
585 }
586
587 auto h_groups = ReadMessageFromFile<HumanDoorGroups>(path.string());
588
589 for (const HumanDoorGroup& h_group : h_groups.door_groups()) {
590 ProcessDoorGroup(h_group);
591 }
592 }
593
594 void ProcessDoorGroup(const HumanDoorGroup& h_group) {
595 uint64_t group_id = container_.FindOrAddDoorGroup(h_group.name());
596 DoorGroup& group = *container_.all_objects().mutable_door_groups(group_id);
597
598 group.set_type(h_group.type());
599
600 for (const DoorIdentifier& di : h_group.doors()) {
601 uint64_t door_id =
602 container_.FindOrAddDoor(di.map(), di.name(), std::nullopt);
603 group.add_doors(door_id);
604 }
605 }
606
607 void ProcessGlobalMetadataFile(std::filesystem::path path) {
608 if (!std::filesystem::exists(path)) {
609 return;
610 }
611
612 auto h_metadata = ReadMessageFromFile<HumanGlobalMetadata>(path.string());
613 container_.all_objects().set_version(h_metadata.version());
614 }
615
547 void ProcessIdsFile(std::filesystem::path path) { 616 void ProcessIdsFile(std::filesystem::path path) {
548 auto ids = ReadIdsFromYaml(path.string()); 617 auto ids = ReadIdsFromYaml(path.string());
549 618
@@ -568,6 +637,14 @@ class DataPacker {
568 .mutable_masteries(mastery_id) 637 .mutable_masteries(mastery_id)
569 ->set_ap_id(ap_id); 638 ->set_ap_id(ap_id);
570 } 639 }
640
641 for (const auto& [keyholder_name, ap_id] : room.keyholders()) {
642 uint64_t keyholder_id = container_.FindOrAddKeyholder(
643 map_name, room_name, keyholder_name, std::nullopt, std::nullopt);
644 container_.all_objects()
645 .mutable_keyholders(keyholder_id)
646 ->set_ap_id(ap_id);
647 }
571 } 648 }
572 } 649 }
573 650
@@ -585,6 +662,16 @@ class DataPacker {
585 uint64_t ending_id = container_.FindOrAddEnding(ending_name); 662 uint64_t ending_id = container_.FindOrAddEnding(ending_name);
586 container_.all_objects().mutable_endings(ending_id)->set_ap_id(ap_id); 663 container_.all_objects().mutable_endings(ending_id)->set_ap_id(ap_id);
587 } 664 }
665
666 for (const auto& [prog_name, ap_id] : ids.progressives()) {
667 uint64_t prog_id = container_.FindOrAddProgressive(prog_name);
668 container_.all_objects().mutable_progressives(prog_id)->set_ap_id(ap_id);
669 }
670
671 for (const auto& [group_name, ap_id] : ids.door_groups()) {
672 uint64_t group_id = container_.FindOrAddDoorGroup(group_name);
673 container_.all_objects().mutable_door_groups(group_id)->set_ap_id(ap_id);
674 }
588 } 675 }
589 676
590 std::string mapdir_; 677 std::string mapdir_;
diff --git a/tools/util/godot_scene.cpp b/tools/util/godot_scene.cpp index 1e77c9e..f788d21 100644 --- a/tools/util/godot_scene.cpp +++ b/tools/util/godot_scene.cpp
@@ -1,10 +1,8 @@
1#include "godot_scene.h" 1#include "godot_scene.h"
2 2
3#include <absl/strings/str_split.h>
4#include <absl/strings/string_view.h>
5
6#include <fstream> 3#include <fstream>
7#include <sstream> 4#include <sstream>
5#include <string_view>
8#include <variant> 6#include <variant>
9 7
10namespace com::fourisland::lingo2_archipelago { 8namespace com::fourisland::lingo2_archipelago {
@@ -23,7 +21,7 @@ struct Heading {
23 GodotInstanceType instance_type; 21 GodotInstanceType instance_type;
24}; 22};
25 23
26Heading ParseTscnHeading(absl::string_view line) { 24Heading ParseTscnHeading(std::string_view line) {
27 std::string original_line(line); 25 std::string original_line(line);
28 Heading heading; 26 Heading heading;
29 27
diff --git a/tools/util/ids_yaml_format.cpp b/tools/util/ids_yaml_format.cpp index f72f60e..71bfd63 100644 --- a/tools/util/ids_yaml_format.cpp +++ b/tools/util/ids_yaml_format.cpp
@@ -56,6 +56,14 @@ IdMappings ReadIdsFromYaml(const std::string& filename) {
56 mastery_it.second.as<uint64_t>(); 56 mastery_it.second.as<uint64_t>();
57 } 57 }
58 } 58 }
59
60 if (room_it.second["keyholders"]) {
61 for (const auto& keyholder_it : room_it.second["keyholders"]) {
62 (*room_ids.mutable_keyholders())[keyholder_it.first
63 .as<std::string>()] =
64 keyholder_it.second.as<uint64_t>();
65 }
66 }
59 } 67 }
60 } 68 }
61 69
@@ -89,6 +97,20 @@ IdMappings ReadIdsFromYaml(const std::string& filename) {
89 } 97 }
90 } 98 }
91 99
100 if (document["progressives"]) {
101 for (const auto& prog_it : document["progressives"]) {
102 (*result.mutable_progressives())[prog_it.first.as<std::string>()] =
103 prog_it.second.as<uint64_t>();
104 }
105 }
106
107 if (document["door_groups"]) {
108 for (const auto& group_it : document["door_groups"]) {
109 (*result.mutable_door_groups())[group_it.first.as<std::string>()] =
110 group_it.second.as<uint64_t>();
111 }
112 }
113
92 return result; 114 return result;
93} 115}
94 116
@@ -117,6 +139,13 @@ void WriteIdsAsYaml(const IdMappings& ids, const std::string& filename) {
117 mastery_id; 139 mastery_id;
118 }); 140 });
119 141
142 OperateOnSortedMap(room_ids.keyholders(),
143 [&room_node](const std::string& keyholder_name,
144 uint64_t keyholder_id) {
145 room_node["keyholders"][keyholder_name] =
146 keyholder_id;
147 });
148
120 map_node["rooms"][room_name] = std::move(room_node); 149 map_node["rooms"][room_name] = std::move(room_node);
121 }); 150 });
122 151
@@ -144,6 +173,16 @@ void WriteIdsAsYaml(const IdMappings& ids, const std::string& filename) {
144 result["special"][special_name] = special_id; 173 result["special"][special_name] = special_id;
145 }); 174 });
146 175
176 OperateOnSortedMap(ids.progressives(),
177 [&result](const std::string& prog_name, uint64_t prog_id) {
178 result["progressives"][prog_name] = prog_id;
179 });
180
181 OperateOnSortedMap(ids.door_groups(), [&result](const std::string& group_name,
182 uint64_t group_id) {
183 result["door_groups"][group_name] = group_id;
184 });
185
147 std::ofstream output_stream(filename); 186 std::ofstream output_stream(filename);
148 output_stream << result << std::endl; 187 output_stream << result << std::endl;
149} 188}
diff --git a/tools/validator/human_processor.cpp b/tools/validator/human_processor.cpp index 0f63936..2c978bf 100644 --- a/tools/validator/human_processor.cpp +++ b/tools/validator/human_processor.cpp
@@ -13,6 +13,7 @@
13#include <string> 13#include <string>
14 14
15#include "structs.h" 15#include "structs.h"
16#include "util/ids_yaml_format.h"
16 17
17namespace com::fourisland::lingo2_archipelago { 18namespace com::fourisland::lingo2_archipelago {
18namespace { 19namespace {
@@ -41,7 +42,9 @@ class HumanProcessor {
41 42
42 ProcessConnectionsFile(datadir_path / "connections.txtpb", std::nullopt); 43 ProcessConnectionsFile(datadir_path / "connections.txtpb", std::nullopt);
43 ProcessMaps(datadir_path); 44 ProcessMaps(datadir_path);
44 ProcessIdsFile(datadir_path / "ids.txtpb"); 45 ProcessProgressivesFile(datadir_path / "progressives.txtpb");
46 ProcessDoorGroupsFile(datadir_path / "door_groups.txtpb");
47 ProcessIdsFile(datadir_path / "ids.yaml");
45 } 48 }
46 49
47 private: 50 private:
@@ -391,7 +394,9 @@ class HumanProcessor {
391 } 394 }
392 } else if (human_connection.has_from()) { 395 } else if (human_connection.has_from()) {
393 ProcessSingleConnection(human_connection, human_connection.from(), 396 ProcessSingleConnection(human_connection, human_connection.from(),
394 current_map_name); 397 current_map_name,
398 /*is_target=*/!human_connection.oneway() &&
399 !human_connection.bypass_target_door());
395 } 400 }
396 401
397 if (human_connection.has_to_room()) { 402 if (human_connection.has_to_room()) {
@@ -407,8 +412,9 @@ class HumanProcessor {
407 std::cout << "A global connection used to_room." << std::endl; 412 std::cout << "A global connection used to_room." << std::endl;
408 } 413 }
409 } else if (human_connection.has_to()) { 414 } else if (human_connection.has_to()) {
410 ProcessSingleConnection(human_connection, human_connection.to(), 415 ProcessSingleConnection(
411 current_map_name); 416 human_connection, human_connection.to(), current_map_name,
417 /*is_target=*/!human_connection.bypass_target_door());
412 } 418 }
413 419
414 if (human_connection.has_door()) { 420 if (human_connection.has_door()) {
@@ -429,7 +435,7 @@ class HumanProcessor {
429 void ProcessSingleConnection( 435 void ProcessSingleConnection(
430 const HumanConnection& human_connection, 436 const HumanConnection& human_connection,
431 const HumanConnection::Endpoint& endpoint, 437 const HumanConnection::Endpoint& endpoint,
432 const std::optional<std::string>& current_map_name) { 438 const std::optional<std::string>& current_map_name, bool is_target) {
433 if (endpoint.has_room()) { 439 if (endpoint.has_room()) {
434 auto room_identifier = 440 auto room_identifier =
435 GetCompleteRoomIdentifier(endpoint.room(), current_map_name); 441 GetCompleteRoomIdentifier(endpoint.room(), current_map_name);
@@ -448,6 +454,11 @@ class HumanProcessor {
448 if (painting_identifier) { 454 if (painting_identifier) {
449 PaintingInfo& painting_info = info_.paintings[*painting_identifier]; 455 PaintingInfo& painting_info = info_.paintings[*painting_identifier];
450 painting_info.connections_referenced_by.push_back(human_connection); 456 painting_info.connections_referenced_by.push_back(human_connection);
457
458 if (is_target) {
459 painting_info.target_connections_referenced_by.push_back(
460 human_connection);
461 }
451 } else { 462 } else {
452 // Not sure where else to store this right now. 463 // Not sure where else to store this right now.
453 std::cout 464 std::cout
@@ -460,6 +471,11 @@ class HumanProcessor {
460 if (port_identifier) { 471 if (port_identifier) {
461 PortInfo& port_info = info_.ports[*port_identifier]; 472 PortInfo& port_info = info_.ports[*port_identifier];
462 port_info.connections_referenced_by.push_back(human_connection); 473 port_info.connections_referenced_by.push_back(human_connection);
474
475 if (is_target) {
476 port_info.target_connections_referenced_by.push_back(
477 human_connection);
478 }
463 } else { 479 } else {
464 // Not sure where else to store this right now. 480 // Not sure where else to store this right now.
465 std::cout 481 std::cout
@@ -477,12 +493,137 @@ class HumanProcessor {
477 panel_info.proxies[endpoint.panel().answer()] 493 panel_info.proxies[endpoint.panel().answer()]
478 .connections_referenced_by.push_back(human_connection); 494 .connections_referenced_by.push_back(human_connection);
479 } 495 }
496
497 if (is_target) {
498 panel_info.target_connections_referenced_by.push_back(
499 human_connection);
500 }
501 }
502 }
503 }
504
505 void ProcessProgressivesFile(std::filesystem::path path) {
506 if (!std::filesystem::exists(path)) {
507 return;
508 }
509
510 auto h_progs = ReadMessageFromFile<HumanProgressives>(path.string());
511
512 for (const HumanProgressive& h_prog : h_progs.progressives()) {
513 ProcessProgressive(h_prog);
514 }
515 }
516
517 void ProcessProgressive(const HumanProgressive& h_prog) {
518 ProgressiveInfo& prog_info = info_.progressives[h_prog.name()];
519 prog_info.definitions.push_back(h_prog);
520
521 for (const DoorIdentifier& di : h_prog.doors()) {
522 if (!di.has_map()) {
523 prog_info.malformed_doors.push_back(di);
524 continue;
525 }
526
527 DoorInfo& door_info = info_.doors[di];
528 door_info.progressives_referenced_by.push_back(h_prog.name());
529 }
530 }
531
532 void ProcessDoorGroupsFile(std::filesystem::path path) {
533 if (!std::filesystem::exists(path)) {
534 return;
535 }
536
537 auto h_groups = ReadMessageFromFile<HumanDoorGroups>(path.string());
538
539 for (const HumanDoorGroup& h_group : h_groups.door_groups()) {
540 ProcessDoorGroup(h_group);
541 }
542 }
543
544 void ProcessDoorGroup(const HumanDoorGroup& h_group) {
545 DoorGroupInfo& group_info = info_.door_groups[h_group.name()];
546 group_info.definitions.push_back(h_group);
547
548 for (const DoorIdentifier& di : h_group.doors()) {
549 if (!di.has_map()) {
550 group_info.malformed_doors.push_back(di);
551 continue;
480 } 552 }
553
554 DoorInfo& door_info = info_.doors[di];
555 door_info.door_groups_referenced_by.push_back(h_group.name());
481 } 556 }
482 } 557 }
483 558
484 void ProcessIdsFile(std::filesystem::path path) { 559 void ProcessIdsFile(std::filesystem::path path) {
485 // Ignore this for now. 560 auto ids = ReadIdsFromYaml(path.string());
561
562 DoorIdentifier di;
563 PanelIdentifier pi;
564 KeyholderIdentifier ki;
565
566 for (const auto& [map_name, map] : ids.maps()) {
567 di.set_map(map_name);
568 pi.set_map(map_name);
569 ki.set_map(map_name);
570
571 for (const auto& [door_name, ap_id] : map.doors()) {
572 di.set_name(door_name);
573
574 DoorInfo& door_info = info_.doors[di];
575 door_info.has_id = true;
576 }
577
578 for (const auto& [room_name, room] : map.rooms()) {
579 pi.set_room(room_name);
580 ki.set_room(room_name);
581
582 for (const auto& [panel_name, ap_id] : room.panels()) {
583 pi.set_name(panel_name);
584
585 PanelInfo& panel_info = info_.panels[pi];
586 panel_info.has_id = true;
587 }
588
589 for (const auto& [mastery_name, ap_id] : room.masteries()) {
590 // TODO: Mastery
591 }
592
593 for (const auto& [keyholder_name, ap_id] : room.keyholders()) {
594 ki.set_name(keyholder_name);
595
596 KeyholderInfo& keyholder_info = info_.keyholders[ki];
597 keyholder_info.has_id = true;
598 }
599 }
600 }
601
602 for (const auto& [tag, id] : ids.special()) {
603 // TODO: Specials
604 }
605
606 for (const auto& [letter_name, ap_id] : ids.letters()) {
607 LetterIdentifier li =
608 std::make_tuple(letter_name[0], letter_name[1] == '2');
609 LetterInfo& letter_info = info_.letters[li];
610 letter_info.has_id = true;
611 }
612
613 for (const auto& [ending_name, ap_id] : ids.endings()) {
614 EndingInfo& ending_info = info_.endings[ending_name];
615 ending_info.has_id = true;
616 }
617
618 for (const auto& [prog_name, ap_id] : ids.progressives()) {
619 ProgressiveInfo& prog_info = info_.progressives[prog_name];
620 prog_info.has_id = true;
621 }
622
623 for (const auto& [group_name, ap_id] : ids.door_groups()) {
624 DoorGroupInfo& group_info = info_.door_groups[group_name];
625 group_info.has_id = true;
626 }
486 } 627 }
487 628
488 std::string mapdir_; 629 std::string mapdir_;
diff --git a/tools/validator/structs.h b/tools/validator/structs.h index 0ca96fe..d1d45f2 100644 --- a/tools/validator/structs.h +++ b/tools/validator/structs.h
@@ -39,12 +39,15 @@ struct RoomInfo {
39 39
40struct DoorInfo { 40struct DoorInfo {
41 std::vector<HumanDoor> definitions; 41 std::vector<HumanDoor> definitions;
42 bool has_id = false;
42 43
43 std::vector<HumanConnection> connections_referenced_by; 44 std::vector<HumanConnection> connections_referenced_by;
44 std::vector<DoorIdentifier> doors_referenced_by; 45 std::vector<DoorIdentifier> doors_referenced_by;
45 std::vector<PanelIdentifier> panels_referenced_by; 46 std::vector<PanelIdentifier> panels_referenced_by;
46 std::vector<PaintingIdentifier> paintings_referenced_by; 47 std::vector<PaintingIdentifier> paintings_referenced_by;
47 std::vector<PortIdentifier> ports_referenced_by; 48 std::vector<PortIdentifier> ports_referenced_by;
49 std::vector<std::string> progressives_referenced_by;
50 std::vector<std::string> door_groups_referenced_by;
48 51
49 MalformedIdentifiers malformed_identifiers; 52 MalformedIdentifiers malformed_identifiers;
50}; 53};
@@ -53,12 +56,14 @@ struct PortInfo {
53 std::vector<HumanPort> definitions; 56 std::vector<HumanPort> definitions;
54 57
55 std::vector<HumanConnection> connections_referenced_by; 58 std::vector<HumanConnection> connections_referenced_by;
59 std::vector<HumanConnection> target_connections_referenced_by;
56}; 60};
57 61
58struct PaintingInfo { 62struct PaintingInfo {
59 std::vector<HumanPainting> definitions; 63 std::vector<HumanPainting> definitions;
60 64
61 std::vector<HumanConnection> connections_referenced_by; 65 std::vector<HumanConnection> connections_referenced_by;
66 std::vector<HumanConnection> target_connections_referenced_by;
62 std::vector<DoorIdentifier> doors_referenced_by; 67 std::vector<DoorIdentifier> doors_referenced_by;
63}; 68};
64 69
@@ -71,10 +76,12 @@ struct ProxyInfo {
71 76
72struct PanelInfo { 77struct PanelInfo {
73 std::vector<HumanPanel> definitions; 78 std::vector<HumanPanel> definitions;
79 bool has_id = false;
74 80
75 std::string map_area_name; 81 std::string map_area_name;
76 82
77 std::vector<HumanConnection> connections_referenced_by; 83 std::vector<HumanConnection> connections_referenced_by;
84 std::vector<HumanConnection> target_connections_referenced_by;
78 std::vector<DoorIdentifier> doors_referenced_by; 85 std::vector<DoorIdentifier> doors_referenced_by;
79 86
80 std::map<std::string, ProxyInfo> proxies; 87 std::map<std::string, ProxyInfo> proxies;
@@ -82,6 +89,7 @@ struct PanelInfo {
82 89
83struct KeyholderInfo { 90struct KeyholderInfo {
84 std::vector<HumanKeyholder> definitions; 91 std::vector<HumanKeyholder> definitions;
92 bool has_id = false;
85 93
86 std::vector<DoorIdentifier> doors_referenced_by; 94 std::vector<DoorIdentifier> doors_referenced_by;
87}; 95};
@@ -90,10 +98,12 @@ using LetterIdentifier = std::tuple<char, bool>;
90 98
91struct LetterInfo { 99struct LetterInfo {
92 std::vector<RoomIdentifier> defined_in; 100 std::vector<RoomIdentifier> defined_in;
101 bool has_id = false;
93}; 102};
94 103
95struct EndingInfo { 104struct EndingInfo {
96 std::vector<RoomIdentifier> defined_in; 105 std::vector<RoomIdentifier> defined_in;
106 bool has_id = false;
97 107
98 std::vector<DoorIdentifier> doors_referenced_by; 108 std::vector<DoorIdentifier> doors_referenced_by;
99}; 109};
@@ -102,6 +112,20 @@ struct PanelNameInfo {
102 std::vector<PanelIdentifier> panels_used_by; 112 std::vector<PanelIdentifier> panels_used_by;
103}; 113};
104 114
115struct ProgressiveInfo {
116 std::vector<HumanProgressive> definitions;
117 bool has_id = false;
118
119 std::vector<DoorIdentifier> malformed_doors;
120};
121
122struct DoorGroupInfo {
123 std::vector<HumanDoorGroup> definitions;
124 bool has_id = false;
125
126 std::vector<DoorIdentifier> malformed_doors;
127};
128
105struct CollectedInfo { 129struct CollectedInfo {
106 std::map<std::string, MapInfo> maps; 130 std::map<std::string, MapInfo> maps;
107 std::map<RoomIdentifier, RoomInfo, RoomIdentifierLess> rooms; 131 std::map<RoomIdentifier, RoomInfo, RoomIdentifierLess> rooms;
@@ -114,6 +138,8 @@ struct CollectedInfo {
114 std::map<LetterIdentifier, LetterInfo> letters; 138 std::map<LetterIdentifier, LetterInfo> letters;
115 std::map<std::string, EndingInfo> endings; 139 std::map<std::string, EndingInfo> endings;
116 std::map<std::string, PanelNameInfo> panel_names; 140 std::map<std::string, PanelNameInfo> panel_names;
141 std::map<std::string, ProgressiveInfo> progressives;
142 std::map<std::string, DoorGroupInfo> door_groups;
117}; 143};
118 144
119} // namespace com::fourisland::lingo2_archipelago 145} // namespace com::fourisland::lingo2_archipelago
diff --git a/tools/validator/validator.cpp b/tools/validator/validator.cpp index 9c66e09..dd41f5c 100644 --- a/tools/validator/validator.cpp +++ b/tools/validator/validator.cpp
@@ -45,6 +45,12 @@ class Validator {
45 for (const auto& [panel_name, panel_info] : info_.panel_names) { 45 for (const auto& [panel_name, panel_info] : info_.panel_names) {
46 ValidatePanelName(panel_name, panel_info); 46 ValidatePanelName(panel_name, panel_info);
47 } 47 }
48 for (const auto& [prog_name, prog_info] : info_.progressives) {
49 ValidateProgressive(prog_name, prog_info);
50 }
51 for (const auto& [group_name, group_info] : info_.door_groups) {
52 ValidateDoorGroup(group_name, group_info);
53 }
48 } 54 }
49 55
50 private: 56 private:
@@ -100,7 +106,8 @@ class Validator {
100 return false; 106 return false;
101 } 107 }
102 108
103 if (h_door.keyholders_size() > 0 || h_door.endings_size() > 0) { 109 if (h_door.keyholders_size() > 0 || h_door.endings_size() > 0 ||
110 h_door.complete_at() > 0) {
104 return true; 111 return true;
105 } 112 }
106 113
@@ -164,6 +171,20 @@ class Validator {
164 std::cout << " CONNECTION " << connection.ShortDebugString() 171 std::cout << " CONNECTION " << connection.ShortDebugString()
165 << std::endl; 172 << std::endl;
166 } 173 }
174
175 for (const std::string& prog_name :
176 door_info.progressives_referenced_by) {
177 std::cout << " PROGRESSIVE " << prog_name << std::endl;
178 }
179
180 for (const std::string& group_name :
181 door_info.door_groups_referenced_by) {
182 std::cout << " DOOR GROUP " << group_name << std::endl;
183 }
184
185 if (door_info.has_id) {
186 std::cout << " An AP ID is present." << std::endl;
187 }
167 } else if (door_info.definitions.size() > 1) { 188 } else if (door_info.definitions.size() > 1) {
168 std::cout << "Door " << door_identifier.ShortDebugString() 189 std::cout << "Door " << door_identifier.ShortDebugString()
169 << " was defined multiple times." << std::endl; 190 << " was defined multiple times." << std::endl;
@@ -207,6 +228,17 @@ class Validator {
207 << " is a location that depends on double_letters." 228 << " is a location that depends on double_letters."
208 << std::endl; 229 << std::endl;
209 } 230 }
231
232 bool needs_id = (h_door.type() != DoorType::EVENT);
233 if (door_info.has_id != needs_id) {
234 if (needs_id) {
235 std::cout << "Door " << door_identifier.ShortDebugString()
236 << " is missing an AP ID." << std::endl;
237 } else {
238 std::cout << "Door " << door_identifier.ShortDebugString()
239 << " should not have an AP ID." << std::endl;
240 }
241 }
210 } 242 }
211 } 243 }
212 244
@@ -225,6 +257,22 @@ class Validator {
225 std::cout << "Port " << port_identifier.ShortDebugString() 257 std::cout << "Port " << port_identifier.ShortDebugString()
226 << " was defined multiple times." << std::endl; 258 << " was defined multiple times." << std::endl;
227 } 259 }
260
261 if (!port_info.target_connections_referenced_by.empty()) {
262 for (const HumanPort& port : port_info.definitions) {
263 if (port.has_required_door()) {
264 std::cout << "Port " << port_identifier.ShortDebugString()
265 << " has a required door but is the target of a connection:"
266 << std::endl;
267
268 for (const HumanConnection& connection :
269 port_info.target_connections_referenced_by) {
270 std::cout << " CONNECTION " << connection.ShortDebugString()
271 << std::endl;
272 }
273 }
274 }
275 }
228 } 276 }
229 277
230 void ValidatePainting(const PaintingIdentifier& painting_identifier, 278 void ValidatePainting(const PaintingIdentifier& painting_identifier,
@@ -248,6 +296,22 @@ class Validator {
248 std::cout << "Painting " << painting_identifier.ShortDebugString() 296 std::cout << "Painting " << painting_identifier.ShortDebugString()
249 << " was defined multiple times." << std::endl; 297 << " was defined multiple times." << std::endl;
250 } 298 }
299
300 if (!painting_info.target_connections_referenced_by.empty()) {
301 for (const HumanPainting& painting : painting_info.definitions) {
302 if (painting.has_required_door()) {
303 std::cout << "Painting " << painting_identifier.ShortDebugString()
304 << " has a required door but is the target of a connection:"
305 << std::endl;
306
307 for (const HumanConnection& connection :
308 painting_info.target_connections_referenced_by) {
309 std::cout << " CONNECTION " << connection.ShortDebugString()
310 << std::endl;
311 }
312 }
313 }
314 }
251 } 315 }
252 316
253 void ValidatePanel(const PanelIdentifier& panel_identifier, 317 void ValidatePanel(const PanelIdentifier& panel_identifier,
@@ -272,6 +336,10 @@ class Validator {
272 std::cout << " CONNECTION " << connection.ShortDebugString() 336 std::cout << " CONNECTION " << connection.ShortDebugString()
273 << std::endl; 337 << std::endl;
274 } 338 }
339
340 if (panel_info.has_id) {
341 std::cout << " An AP ID is present." << std::endl;
342 }
275 } else if (panel_info.definitions.size() > 1) { 343 } else if (panel_info.definitions.size() > 1) {
276 std::cout << "Panel " << panel_identifier.ShortDebugString() 344 std::cout << "Panel " << panel_identifier.ShortDebugString()
277 << " was defined multiple times." << std::endl; 345 << " was defined multiple times." << std::endl;
@@ -300,6 +368,27 @@ class Validator {
300 << "\" was defined multiple times." << std::endl; 368 << "\" was defined multiple times." << std::endl;
301 } 369 }
302 } 370 }
371
372 if (!panel_info.has_id) {
373 std::cout << "Panel " << panel_identifier.ShortDebugString()
374 << " is missing an AP ID." << std::endl;
375 }
376
377 if (!panel_info.target_connections_referenced_by.empty()) {
378 for (const HumanPanel& panel : panel_info.definitions) {
379 if (panel.has_required_door()) {
380 std::cout << "Panel " << panel_identifier.ShortDebugString()
381 << " has a required door but is the target of a connection:"
382 << std::endl;
383
384 for (const HumanConnection& connection :
385 panel_info.target_connections_referenced_by) {
386 std::cout << " CONNECTION " << connection.ShortDebugString()
387 << std::endl;
388 }
389 }
390 }
391 }
303 } 392 }
304 393
305 void ValidateKeyholder(const KeyholderIdentifier& keyholder_identifier, 394 void ValidateKeyholder(const KeyholderIdentifier& keyholder_identifier,
@@ -313,10 +402,28 @@ class Validator {
313 std::cout << " DOOR " << door_identifier.ShortDebugString() 402 std::cout << " DOOR " << door_identifier.ShortDebugString()
314 << std::endl; 403 << std::endl;
315 } 404 }
405
406 if (keyholder_info.has_id) {
407 std::cout << " An AP ID is present." << std::endl;
408 }
316 } else if (keyholder_info.definitions.size() > 1) { 409 } else if (keyholder_info.definitions.size() > 1) {
317 std::cout << "Keyholder " << keyholder_identifier.ShortDebugString() 410 std::cout << "Keyholder " << keyholder_identifier.ShortDebugString()
318 << " was defined multiple times." << std::endl; 411 << " was defined multiple times." << std::endl;
319 } 412 }
413
414 for (const HumanKeyholder& h_keyholder : keyholder_info.definitions) {
415 bool needs_id = (h_keyholder.has_key());
416
417 if (needs_id != keyholder_info.has_id) {
418 if (needs_id) {
419 std::cout << "Keyholder " << keyholder_identifier.ShortDebugString()
420 << " is missing an AP ID." << std::endl;
421 } else {
422 std::cout << "Keyholder " << keyholder_identifier.ShortDebugString()
423 << " should not have an AP ID." << std::endl;
424 }
425 }
426 }
320 } 427 }
321 428
322 void ValidateLetter(const LetterIdentifier& letter_identifier, 429 void ValidateLetter(const LetterIdentifier& letter_identifier,
@@ -324,7 +431,14 @@ class Validator {
324 std::string letter_name = std::string(1, std::get<0>(letter_identifier)) + 431 std::string letter_name = std::string(1, std::get<0>(letter_identifier)) +
325 (std::get<1>(letter_identifier) ? "2" : "1"); 432 (std::get<1>(letter_identifier) ? "2" : "1");
326 433
327 if (letter_info.defined_in.size() > 1) { 434 if (letter_info.defined_in.empty()) {
435 std::cout << "Letter " << letter_name
436 << " has no definition, but was referenced:" << std::endl;
437
438 if (letter_info.has_id) {
439 std::cout << " An AP ID is present." << std::endl;
440 }
441 } else if (letter_info.defined_in.size() > 1) {
328 std::cout << "Letter " << letter_name 442 std::cout << "Letter " << letter_name
329 << " was defined in multiple places:" << std::endl; 443 << " was defined in multiple places:" << std::endl;
330 444
@@ -332,6 +446,11 @@ class Validator {
332 std::cout << " " << room_identifier.ShortDebugString() << std::endl; 446 std::cout << " " << room_identifier.ShortDebugString() << std::endl;
333 } 447 }
334 } 448 }
449
450 if (!letter_info.has_id) {
451 std::cout << "Letter " << letter_name << " is missing an AP ID."
452 << std::endl;
453 }
335 } 454 }
336 455
337 void ValidateEnding(const std::string& ending_name, 456 void ValidateEnding(const std::string& ending_name,
@@ -345,6 +464,10 @@ class Validator {
345 std::cout << " DOOR " << door_identifier.ShortDebugString() 464 std::cout << " DOOR " << door_identifier.ShortDebugString()
346 << std::endl; 465 << std::endl;
347 } 466 }
467
468 if (ending_info.has_id) {
469 std::cout << " An AP ID is present." << std::endl;
470 }
348 } else if (ending_info.defined_in.size() > 1) { 471 } else if (ending_info.defined_in.size() > 1) {
349 std::cout << "Ending " << ending_name 472 std::cout << "Ending " << ending_name
350 << " was defined in multiple places:" << std::endl; 473 << " was defined in multiple places:" << std::endl;
@@ -353,6 +476,11 @@ class Validator {
353 std::cout << " " << room_identifier.ShortDebugString() << std::endl; 476 std::cout << " " << room_identifier.ShortDebugString() << std::endl;
354 } 477 }
355 } 478 }
479
480 if (!ending_info.has_id) {
481 std::cout << "Ending " << ending_name << " is missing an AP ID."
482 << std::endl;
483 }
356 } 484 }
357 485
358 void ValidatePanelName(const std::string& panel_name, 486 void ValidatePanelName(const std::string& panel_name,
@@ -369,6 +497,46 @@ class Validator {
369 } 497 }
370 } 498 }
371 499
500 void ValidateProgressive(const std::string& prog_name,
501 const ProgressiveInfo& prog_info) const {
502 if (prog_info.definitions.empty()) {
503 std::cout << "Progressive \"" << prog_name
504 << "\" has no definition, but was referenced:" << std::endl;
505
506 if (prog_info.has_id) {
507 std::cout << " An AP ID is present." << std::endl;
508 }
509 } else if (prog_info.definitions.size() > 1) {
510 std::cout << "Progressive \"" << prog_name
511 << "\" has multiple definitions." << std::endl;
512 }
513
514 if (!prog_info.has_id) {
515 std::cout << "Progressive \"" << prog_name << "\" is missing an AP ID."
516 << std::endl;
517 }
518 }
519
520 void ValidateDoorGroup(const std::string& group_name,
521 const DoorGroupInfo& group_info) const {
522 if (group_info.definitions.empty()) {
523 std::cout << "Door group \"" << group_name
524 << "\" has no definition, but was referenced:" << std::endl;
525
526 if (group_info.has_id) {
527 std::cout << " An AP ID is present." << std::endl;
528 }
529 } else if (group_info.definitions.size() > 1) {
530 std::cout << "Door group \"" << group_name
531 << "\" has multiple definitions." << std::endl;
532 }
533
534 if (!group_info.has_id) {
535 std::cout << "Door group \"" << group_name << "\" is missing an AP ID."
536 << std::endl;
537 }
538 }
539
372 const CollectedInfo& info_; 540 const CollectedInfo& info_;
373}; 541};
374 542