diff options
Diffstat (limited to 'tools')
| -rw-r--r-- | tools/assign_ids/main.cpp | 39 | ||||
| -rw-r--r-- | tools/datapacker/container.cpp | 17 | ||||
| -rw-r--r-- | tools/datapacker/container.h | 3 | ||||
| -rw-r--r-- | tools/datapacker/main.cpp | 45 | ||||
| -rw-r--r-- | tools/util/godot_scene.cpp | 6 | ||||
| -rw-r--r-- | tools/util/ids_yaml_format.cpp | 12 | ||||
| -rw-r--r-- | tools/validator/human_processor.cpp | 59 | ||||
| -rw-r--r-- | tools/validator/structs.h | 12 | ||||
| -rw-r--r-- | tools/validator/validator.cpp | 79 |
9 files changed, 261 insertions, 11 deletions
| diff --git a/tools/assign_ids/main.cpp b/tools/assign_ids/main.cpp index e3add66..3e16f78 100644 --- a/tools/assign_ids/main.cpp +++ b/tools/assign_ids/main.cpp | |||
| @@ -2,6 +2,7 @@ | |||
| 2 | #include <google/protobuf/text_format.h> | 2 | #include <google/protobuf/text_format.h> |
| 3 | 3 | ||
| 4 | #include <cstdint> | 4 | #include <cstdint> |
| 5 | #include <filesystem> | ||
| 5 | #include <fstream> | 6 | #include <fstream> |
| 6 | #include <iostream> | 7 | #include <iostream> |
| 7 | #include <map> | 8 | #include <map> |
| @@ -42,6 +43,8 @@ class AssignIds { | |||
| 42 | ProcessMaps(datadir_path); | 43 | ProcessMaps(datadir_path); |
| 43 | ProcessSpecialIds(); | 44 | ProcessSpecialIds(); |
| 44 | ProcessProgressivesFile(datadir_path / "progressives.txtpb"); | 45 | ProcessProgressivesFile(datadir_path / "progressives.txtpb"); |
| 46 | ProcessDoorGroupsFile(datadir_path / "door_groups.txtpb"); | ||
| 47 | ProcessGlobalMetadataFile(datadir_path / "metadata.txtpb"); | ||
| 45 | 48 | ||
| 46 | WriteIds(ids_path); | 49 | WriteIds(ids_path); |
| 47 | 50 | ||
| @@ -61,6 +64,7 @@ class AssignIds { | |||
| 61 | for (const auto& [_, room] : map.rooms()) { | 64 | for (const auto& [_, room] : map.rooms()) { |
| 62 | UpdateNextId(room.panels()); | 65 | UpdateNextId(room.panels()); |
| 63 | UpdateNextId(room.masteries()); | 66 | UpdateNextId(room.masteries()); |
| 67 | UpdateNextId(room.keyholders()); | ||
| 64 | } | 68 | } |
| 65 | } | 69 | } |
| 66 | 70 | ||
| @@ -68,6 +72,7 @@ class AssignIds { | |||
| 68 | UpdateNextId(id_mappings_.letters()); | 72 | UpdateNextId(id_mappings_.letters()); |
| 69 | UpdateNextId(id_mappings_.endings()); | 73 | UpdateNextId(id_mappings_.endings()); |
| 70 | UpdateNextId(id_mappings_.progressives()); | 74 | UpdateNextId(id_mappings_.progressives()); |
| 75 | UpdateNextId(id_mappings_.door_groups()); | ||
| 71 | 76 | ||
| 72 | next_id_++; | 77 | next_id_++; |
| 73 | } | 78 | } |
| @@ -267,6 +272,40 @@ class AssignIds { | |||
| 267 | } | 272 | } |
| 268 | } | 273 | } |
| 269 | 274 | ||
| 275 | void ProcessDoorGroupsFile(std::filesystem::path path) { | ||
| 276 | if (!std::filesystem::exists(path)) { | ||
| 277 | return; | ||
| 278 | } | ||
| 279 | |||
| 280 | auto h_groups = ReadMessageFromFile<HumanDoorGroups>(path.string()); | ||
| 281 | auto& groups = *output_.mutable_door_groups(); | ||
| 282 | |||
| 283 | for (const HumanDoorGroup& h_group : h_groups.door_groups()) { | ||
| 284 | if (!id_mappings_.door_groups().contains(h_group.name())) { | ||
| 285 | groups[h_group.name()] = next_id_++; | ||
| 286 | } else { | ||
| 287 | groups[h_group.name()] = id_mappings_.door_groups().at(h_group.name()); | ||
| 288 | } | ||
| 289 | } | ||
| 290 | } | ||
| 291 | |||
| 292 | void ProcessGlobalMetadataFile(std::filesystem::path path) { | ||
| 293 | if (!std::filesystem::exists(path)) { | ||
| 294 | return; | ||
| 295 | } | ||
| 296 | |||
| 297 | auto h_metadata = ReadMessageFromFile<HumanGlobalMetadata>(path.string()); | ||
| 298 | auto& specials = *output_.mutable_special(); | ||
| 299 | |||
| 300 | for (const std::string& h_special : h_metadata.special_names()) { | ||
| 301 | if (!id_mappings_.special().contains(h_special)) { | ||
| 302 | specials[h_special] = next_id_++; | ||
| 303 | } else { | ||
| 304 | specials[h_special] = id_mappings_.special().at(h_special); | ||
| 305 | } | ||
| 306 | } | ||
| 307 | } | ||
| 308 | |||
| 270 | private: | 309 | private: |
| 271 | void UpdateNextId(const google::protobuf::Map<std::string, uint64_t>& ids) { | 310 | void UpdateNextId(const google::protobuf::Map<std::string, uint64_t>& ids) { |
| 272 | for (const auto& [_, id] : ids) { | 311 | for (const auto& [_, id] : ids) { |
| diff --git a/tools/datapacker/container.cpp b/tools/datapacker/container.cpp index 624caf8..4a656b3 100644 --- a/tools/datapacker/container.cpp +++ b/tools/datapacker/container.cpp | |||
| @@ -348,6 +348,23 @@ uint64_t Container::FindOrAddProgressive(std::string prog_name) { | |||
| 348 | } | 348 | } |
| 349 | } | 349 | } |
| 350 | 350 | ||
| 351 | uint64_t Container::FindOrAddDoorGroup(std::string group_name) { | ||
| 352 | auto it = door_group_id_by_name_.find(group_name); | ||
| 353 | |||
| 354 | if (it == door_group_id_by_name_.end()) { | ||
| 355 | uint64_t new_id = all_objects_.door_groups_size(); | ||
| 356 | DoorGroup* door_group = all_objects_.add_door_groups(); | ||
| 357 | door_group->set_id(new_id); | ||
| 358 | door_group->set_name(group_name); | ||
| 359 | |||
| 360 | door_group_id_by_name_[group_name] = new_id; | ||
| 361 | |||
| 362 | return new_id; | ||
| 363 | } else { | ||
| 364 | return it->second; | ||
| 365 | } | ||
| 366 | } | ||
| 367 | |||
| 351 | void Container::AddConnection(const Connection& connection) { | 368 | void Container::AddConnection(const Connection& connection) { |
| 352 | *all_objects_.add_connections() = connection; | 369 | *all_objects_.add_connections() = connection; |
| 353 | } | 370 | } |
| diff --git a/tools/datapacker/container.h b/tools/datapacker/container.h index 8cec560..bc02ba4 100644 --- a/tools/datapacker/container.h +++ b/tools/datapacker/container.h | |||
| @@ -62,6 +62,8 @@ class Container { | |||
| 62 | 62 | ||
| 63 | uint64_t FindOrAddProgressive(std::string prog_name); | 63 | uint64_t FindOrAddProgressive(std::string prog_name); |
| 64 | 64 | ||
| 65 | uint64_t FindOrAddDoorGroup(std::string group_name); | ||
| 66 | |||
| 65 | AllObjects& all_objects() { return all_objects_; } | 67 | AllObjects& all_objects() { return all_objects_; } |
| 66 | 68 | ||
| 67 | private: | 69 | private: |
| @@ -85,6 +87,7 @@ class Container { | |||
| 85 | door_id_by_map_door_names_; | 87 | door_id_by_map_door_names_; |
| 86 | std::map<std::string, uint64_t> ending_id_by_name_; | 88 | std::map<std::string, uint64_t> ending_id_by_name_; |
| 87 | std::map<std::string, uint64_t> progressive_id_by_name_; | 89 | std::map<std::string, uint64_t> progressive_id_by_name_; |
| 90 | std::map<std::string, uint64_t> door_group_id_by_name_; | ||
| 88 | }; | 91 | }; |
| 89 | 92 | ||
| 90 | } // namespace com::fourisland::lingo2_archipelago | 93 | } // namespace com::fourisland::lingo2_archipelago |
| diff --git a/tools/datapacker/main.cpp b/tools/datapacker/main.cpp index 595647d..c13a4df 100644 --- a/tools/datapacker/main.cpp +++ b/tools/datapacker/main.cpp | |||
| @@ -44,6 +44,8 @@ class DataPacker { | |||
| 44 | ProcessConnectionsFile(datadir_path / "connections.txtpb", std::nullopt); | 44 | ProcessConnectionsFile(datadir_path / "connections.txtpb", std::nullopt); |
| 45 | ProcessMaps(datadir_path); | 45 | ProcessMaps(datadir_path); |
| 46 | ProcessProgressivesFile(datadir_path / "progressives.txtpb"); | 46 | ProcessProgressivesFile(datadir_path / "progressives.txtpb"); |
| 47 | ProcessDoorGroupsFile(datadir_path / "door_groups.txtpb"); | ||
| 48 | ProcessGlobalMetadataFile(datadir_path / "metadata.txtpb"); | ||
| 47 | ProcessIdsFile(datadir_path / "ids.yaml"); | 49 | ProcessIdsFile(datadir_path / "ids.yaml"); |
| 48 | 50 | ||
| 49 | { | 51 | { |
| @@ -344,8 +346,8 @@ class DataPacker { | |||
| 344 | h_door.receivers().begin(), h_door.receivers().end(), | 346 | h_door.receivers().begin(), h_door.receivers().end(), |
| 345 | google::protobuf::RepeatedFieldBackInserter(door.mutable_receivers())); | 347 | google::protobuf::RepeatedFieldBackInserter(door.mutable_receivers())); |
| 346 | std::copy( | 348 | std::copy( |
| 347 | h_door.switches().begin(), h_door.switches().end(), | 349 | h_door.senders().begin(), h_door.senders().end(), |
| 348 | google::protobuf::RepeatedFieldBackInserter(door.mutable_switches())); | 350 | google::protobuf::RepeatedFieldBackInserter(door.mutable_senders())); |
| 349 | 351 | ||
| 350 | for (const PaintingIdentifier& pi : h_door.move_paintings()) { | 352 | for (const PaintingIdentifier& pi : h_door.move_paintings()) { |
| 351 | std::optional<std::string> map_name = | 353 | std::optional<std::string> map_name = |
| @@ -577,6 +579,40 @@ class DataPacker { | |||
| 577 | } | 579 | } |
| 578 | } | 580 | } |
| 579 | 581 | ||
| 582 | void ProcessDoorGroupsFile(std::filesystem::path path) { | ||
| 583 | if (!std::filesystem::exists(path)) { | ||
| 584 | return; | ||
| 585 | } | ||
| 586 | |||
| 587 | auto h_groups = ReadMessageFromFile<HumanDoorGroups>(path.string()); | ||
| 588 | |||
| 589 | for (const HumanDoorGroup& h_group : h_groups.door_groups()) { | ||
| 590 | ProcessDoorGroup(h_group); | ||
| 591 | } | ||
| 592 | } | ||
| 593 | |||
| 594 | void ProcessDoorGroup(const HumanDoorGroup& h_group) { | ||
| 595 | uint64_t group_id = container_.FindOrAddDoorGroup(h_group.name()); | ||
| 596 | DoorGroup& group = *container_.all_objects().mutable_door_groups(group_id); | ||
| 597 | |||
| 598 | group.set_type(h_group.type()); | ||
| 599 | |||
| 600 | for (const DoorIdentifier& di : h_group.doors()) { | ||
| 601 | uint64_t door_id = | ||
| 602 | container_.FindOrAddDoor(di.map(), di.name(), std::nullopt); | ||
| 603 | group.add_doors(door_id); | ||
| 604 | } | ||
| 605 | } | ||
| 606 | |||
| 607 | void ProcessGlobalMetadataFile(std::filesystem::path path) { | ||
| 608 | if (!std::filesystem::exists(path)) { | ||
| 609 | return; | ||
| 610 | } | ||
| 611 | |||
| 612 | auto h_metadata = ReadMessageFromFile<HumanGlobalMetadata>(path.string()); | ||
| 613 | container_.all_objects().set_version(h_metadata.version()); | ||
| 614 | } | ||
| 615 | |||
| 580 | void ProcessIdsFile(std::filesystem::path path) { | 616 | void ProcessIdsFile(std::filesystem::path path) { |
| 581 | auto ids = ReadIdsFromYaml(path.string()); | 617 | auto ids = ReadIdsFromYaml(path.string()); |
| 582 | 618 | ||
| @@ -631,6 +667,11 @@ class DataPacker { | |||
| 631 | uint64_t prog_id = container_.FindOrAddProgressive(prog_name); | 667 | uint64_t prog_id = container_.FindOrAddProgressive(prog_name); |
| 632 | container_.all_objects().mutable_progressives(prog_id)->set_ap_id(ap_id); | 668 | container_.all_objects().mutable_progressives(prog_id)->set_ap_id(ap_id); |
| 633 | } | 669 | } |
| 670 | |||
| 671 | for (const auto& [group_name, ap_id] : ids.door_groups()) { | ||
| 672 | uint64_t group_id = container_.FindOrAddDoorGroup(group_name); | ||
| 673 | container_.all_objects().mutable_door_groups(group_id)->set_ap_id(ap_id); | ||
| 674 | } | ||
| 634 | } | 675 | } |
| 635 | 676 | ||
| 636 | std::string mapdir_; | 677 | std::string mapdir_; |
| diff --git a/tools/util/godot_scene.cpp b/tools/util/godot_scene.cpp index 1e77c9e..f788d21 100644 --- a/tools/util/godot_scene.cpp +++ b/tools/util/godot_scene.cpp | |||
| @@ -1,10 +1,8 @@ | |||
| 1 | #include "godot_scene.h" | 1 | #include "godot_scene.h" |
| 2 | 2 | ||
| 3 | #include <absl/strings/str_split.h> | ||
| 4 | #include <absl/strings/string_view.h> | ||
| 5 | |||
| 6 | #include <fstream> | 3 | #include <fstream> |
| 7 | #include <sstream> | 4 | #include <sstream> |
| 5 | #include <string_view> | ||
| 8 | #include <variant> | 6 | #include <variant> |
| 9 | 7 | ||
| 10 | namespace com::fourisland::lingo2_archipelago { | 8 | namespace com::fourisland::lingo2_archipelago { |
| @@ -23,7 +21,7 @@ struct Heading { | |||
| 23 | GodotInstanceType instance_type; | 21 | GodotInstanceType instance_type; |
| 24 | }; | 22 | }; |
| 25 | 23 | ||
| 26 | Heading ParseTscnHeading(absl::string_view line) { | 24 | Heading ParseTscnHeading(std::string_view line) { |
| 27 | std::string original_line(line); | 25 | std::string original_line(line); |
| 28 | Heading heading; | 26 | Heading heading; |
| 29 | 27 | ||
| diff --git a/tools/util/ids_yaml_format.cpp b/tools/util/ids_yaml_format.cpp index 67c21d6..71bfd63 100644 --- a/tools/util/ids_yaml_format.cpp +++ b/tools/util/ids_yaml_format.cpp | |||
| @@ -104,6 +104,13 @@ IdMappings ReadIdsFromYaml(const std::string& filename) { | |||
| 104 | } | 104 | } |
| 105 | } | 105 | } |
| 106 | 106 | ||
| 107 | if (document["door_groups"]) { | ||
| 108 | for (const auto& group_it : document["door_groups"]) { | ||
| 109 | (*result.mutable_door_groups())[group_it.first.as<std::string>()] = | ||
| 110 | group_it.second.as<uint64_t>(); | ||
| 111 | } | ||
| 112 | } | ||
| 113 | |||
| 107 | return result; | 114 | return result; |
| 108 | } | 115 | } |
| 109 | 116 | ||
| @@ -171,6 +178,11 @@ void WriteIdsAsYaml(const IdMappings& ids, const std::string& filename) { | |||
| 171 | result["progressives"][prog_name] = prog_id; | 178 | result["progressives"][prog_name] = prog_id; |
| 172 | }); | 179 | }); |
| 173 | 180 | ||
| 181 | OperateOnSortedMap(ids.door_groups(), [&result](const std::string& group_name, | ||
| 182 | uint64_t group_id) { | ||
| 183 | result["door_groups"][group_name] = group_id; | ||
| 184 | }); | ||
| 185 | |||
| 174 | std::ofstream output_stream(filename); | 186 | std::ofstream output_stream(filename); |
| 175 | output_stream << result << std::endl; | 187 | output_stream << result << std::endl; |
| 176 | } | 188 | } |
| diff --git a/tools/validator/human_processor.cpp b/tools/validator/human_processor.cpp index 5720ba9..2c978bf 100644 --- a/tools/validator/human_processor.cpp +++ b/tools/validator/human_processor.cpp | |||
| @@ -43,6 +43,7 @@ class HumanProcessor { | |||
| 43 | ProcessConnectionsFile(datadir_path / "connections.txtpb", std::nullopt); | 43 | ProcessConnectionsFile(datadir_path / "connections.txtpb", std::nullopt); |
| 44 | ProcessMaps(datadir_path); | 44 | ProcessMaps(datadir_path); |
| 45 | ProcessProgressivesFile(datadir_path / "progressives.txtpb"); | 45 | ProcessProgressivesFile(datadir_path / "progressives.txtpb"); |
| 46 | ProcessDoorGroupsFile(datadir_path / "door_groups.txtpb"); | ||
| 46 | ProcessIdsFile(datadir_path / "ids.yaml"); | 47 | ProcessIdsFile(datadir_path / "ids.yaml"); |
| 47 | } | 48 | } |
| 48 | 49 | ||
| @@ -393,7 +394,9 @@ class HumanProcessor { | |||
| 393 | } | 394 | } |
| 394 | } else if (human_connection.has_from()) { | 395 | } else if (human_connection.has_from()) { |
| 395 | ProcessSingleConnection(human_connection, human_connection.from(), | 396 | ProcessSingleConnection(human_connection, human_connection.from(), |
| 396 | current_map_name); | 397 | current_map_name, |
| 398 | /*is_target=*/!human_connection.oneway() && | ||
| 399 | !human_connection.bypass_target_door()); | ||
| 397 | } | 400 | } |
| 398 | 401 | ||
| 399 | if (human_connection.has_to_room()) { | 402 | if (human_connection.has_to_room()) { |
| @@ -409,8 +412,9 @@ class HumanProcessor { | |||
| 409 | std::cout << "A global connection used to_room." << std::endl; | 412 | std::cout << "A global connection used to_room." << std::endl; |
| 410 | } | 413 | } |
| 411 | } else if (human_connection.has_to()) { | 414 | } else if (human_connection.has_to()) { |
| 412 | ProcessSingleConnection(human_connection, human_connection.to(), | 415 | ProcessSingleConnection( |
| 413 | current_map_name); | 416 | human_connection, human_connection.to(), current_map_name, |
| 417 | /*is_target=*/!human_connection.bypass_target_door()); | ||
| 414 | } | 418 | } |
| 415 | 419 | ||
| 416 | if (human_connection.has_door()) { | 420 | if (human_connection.has_door()) { |
| @@ -431,7 +435,7 @@ class HumanProcessor { | |||
| 431 | void ProcessSingleConnection( | 435 | void ProcessSingleConnection( |
| 432 | const HumanConnection& human_connection, | 436 | const HumanConnection& human_connection, |
| 433 | const HumanConnection::Endpoint& endpoint, | 437 | const HumanConnection::Endpoint& endpoint, |
| 434 | const std::optional<std::string>& current_map_name) { | 438 | const std::optional<std::string>& current_map_name, bool is_target) { |
| 435 | if (endpoint.has_room()) { | 439 | if (endpoint.has_room()) { |
| 436 | auto room_identifier = | 440 | auto room_identifier = |
| 437 | GetCompleteRoomIdentifier(endpoint.room(), current_map_name); | 441 | GetCompleteRoomIdentifier(endpoint.room(), current_map_name); |
| @@ -450,6 +454,11 @@ class HumanProcessor { | |||
| 450 | if (painting_identifier) { | 454 | if (painting_identifier) { |
| 451 | PaintingInfo& painting_info = info_.paintings[*painting_identifier]; | 455 | PaintingInfo& painting_info = info_.paintings[*painting_identifier]; |
| 452 | painting_info.connections_referenced_by.push_back(human_connection); | 456 | painting_info.connections_referenced_by.push_back(human_connection); |
| 457 | |||
| 458 | if (is_target) { | ||
| 459 | painting_info.target_connections_referenced_by.push_back( | ||
| 460 | human_connection); | ||
| 461 | } | ||
| 453 | } else { | 462 | } else { |
| 454 | // Not sure where else to store this right now. | 463 | // Not sure where else to store this right now. |
| 455 | std::cout | 464 | std::cout |
| @@ -462,6 +471,11 @@ class HumanProcessor { | |||
| 462 | if (port_identifier) { | 471 | if (port_identifier) { |
| 463 | PortInfo& port_info = info_.ports[*port_identifier]; | 472 | PortInfo& port_info = info_.ports[*port_identifier]; |
| 464 | port_info.connections_referenced_by.push_back(human_connection); | 473 | port_info.connections_referenced_by.push_back(human_connection); |
| 474 | |||
| 475 | if (is_target) { | ||
| 476 | port_info.target_connections_referenced_by.push_back( | ||
| 477 | human_connection); | ||
| 478 | } | ||
| 465 | } else { | 479 | } else { |
| 466 | // Not sure where else to store this right now. | 480 | // Not sure where else to store this right now. |
| 467 | std::cout | 481 | std::cout |
| @@ -479,6 +493,11 @@ class HumanProcessor { | |||
| 479 | panel_info.proxies[endpoint.panel().answer()] | 493 | panel_info.proxies[endpoint.panel().answer()] |
| 480 | .connections_referenced_by.push_back(human_connection); | 494 | .connections_referenced_by.push_back(human_connection); |
| 481 | } | 495 | } |
| 496 | |||
| 497 | if (is_target) { | ||
| 498 | panel_info.target_connections_referenced_by.push_back( | ||
| 499 | human_connection); | ||
| 500 | } | ||
| 482 | } | 501 | } |
| 483 | } | 502 | } |
| 484 | } | 503 | } |
| @@ -510,6 +529,33 @@ class HumanProcessor { | |||
| 510 | } | 529 | } |
| 511 | } | 530 | } |
| 512 | 531 | ||
| 532 | void ProcessDoorGroupsFile(std::filesystem::path path) { | ||
| 533 | if (!std::filesystem::exists(path)) { | ||
| 534 | return; | ||
| 535 | } | ||
| 536 | |||
| 537 | auto h_groups = ReadMessageFromFile<HumanDoorGroups>(path.string()); | ||
| 538 | |||
| 539 | for (const HumanDoorGroup& h_group : h_groups.door_groups()) { | ||
| 540 | ProcessDoorGroup(h_group); | ||
| 541 | } | ||
| 542 | } | ||
| 543 | |||
| 544 | void ProcessDoorGroup(const HumanDoorGroup& h_group) { | ||
| 545 | DoorGroupInfo& group_info = info_.door_groups[h_group.name()]; | ||
| 546 | group_info.definitions.push_back(h_group); | ||
| 547 | |||
| 548 | for (const DoorIdentifier& di : h_group.doors()) { | ||
| 549 | if (!di.has_map()) { | ||
| 550 | group_info.malformed_doors.push_back(di); | ||
| 551 | continue; | ||
| 552 | } | ||
| 553 | |||
| 554 | DoorInfo& door_info = info_.doors[di]; | ||
| 555 | door_info.door_groups_referenced_by.push_back(h_group.name()); | ||
| 556 | } | ||
| 557 | } | ||
| 558 | |||
| 513 | void ProcessIdsFile(std::filesystem::path path) { | 559 | void ProcessIdsFile(std::filesystem::path path) { |
| 514 | auto ids = ReadIdsFromYaml(path.string()); | 560 | auto ids = ReadIdsFromYaml(path.string()); |
| 515 | 561 | ||
| @@ -573,6 +619,11 @@ class HumanProcessor { | |||
| 573 | ProgressiveInfo& prog_info = info_.progressives[prog_name]; | 619 | ProgressiveInfo& prog_info = info_.progressives[prog_name]; |
| 574 | prog_info.has_id = true; | 620 | prog_info.has_id = true; |
| 575 | } | 621 | } |
| 622 | |||
| 623 | for (const auto& [group_name, ap_id] : ids.door_groups()) { | ||
| 624 | DoorGroupInfo& group_info = info_.door_groups[group_name]; | ||
| 625 | group_info.has_id = true; | ||
| 626 | } | ||
| 576 | } | 627 | } |
| 577 | 628 | ||
| 578 | std::string mapdir_; | 629 | std::string mapdir_; |
| diff --git a/tools/validator/structs.h b/tools/validator/structs.h index e24ed3d..d1d45f2 100644 --- a/tools/validator/structs.h +++ b/tools/validator/structs.h | |||
| @@ -47,6 +47,7 @@ struct DoorInfo { | |||
| 47 | std::vector<PaintingIdentifier> paintings_referenced_by; | 47 | std::vector<PaintingIdentifier> paintings_referenced_by; |
| 48 | std::vector<PortIdentifier> ports_referenced_by; | 48 | std::vector<PortIdentifier> ports_referenced_by; |
| 49 | std::vector<std::string> progressives_referenced_by; | 49 | std::vector<std::string> progressives_referenced_by; |
| 50 | std::vector<std::string> door_groups_referenced_by; | ||
| 50 | 51 | ||
| 51 | MalformedIdentifiers malformed_identifiers; | 52 | MalformedIdentifiers malformed_identifiers; |
| 52 | }; | 53 | }; |
| @@ -55,12 +56,14 @@ struct PortInfo { | |||
| 55 | std::vector<HumanPort> definitions; | 56 | std::vector<HumanPort> definitions; |
| 56 | 57 | ||
| 57 | std::vector<HumanConnection> connections_referenced_by; | 58 | std::vector<HumanConnection> connections_referenced_by; |
| 59 | std::vector<HumanConnection> target_connections_referenced_by; | ||
| 58 | }; | 60 | }; |
| 59 | 61 | ||
| 60 | struct PaintingInfo { | 62 | struct PaintingInfo { |
| 61 | std::vector<HumanPainting> definitions; | 63 | std::vector<HumanPainting> definitions; |
| 62 | 64 | ||
| 63 | std::vector<HumanConnection> connections_referenced_by; | 65 | std::vector<HumanConnection> connections_referenced_by; |
| 66 | std::vector<HumanConnection> target_connections_referenced_by; | ||
| 64 | std::vector<DoorIdentifier> doors_referenced_by; | 67 | std::vector<DoorIdentifier> doors_referenced_by; |
| 65 | }; | 68 | }; |
| 66 | 69 | ||
| @@ -78,6 +81,7 @@ struct PanelInfo { | |||
| 78 | std::string map_area_name; | 81 | std::string map_area_name; |
| 79 | 82 | ||
| 80 | std::vector<HumanConnection> connections_referenced_by; | 83 | std::vector<HumanConnection> connections_referenced_by; |
| 84 | std::vector<HumanConnection> target_connections_referenced_by; | ||
| 81 | std::vector<DoorIdentifier> doors_referenced_by; | 85 | std::vector<DoorIdentifier> doors_referenced_by; |
| 82 | 86 | ||
| 83 | std::map<std::string, ProxyInfo> proxies; | 87 | std::map<std::string, ProxyInfo> proxies; |
| @@ -115,6 +119,13 @@ struct ProgressiveInfo { | |||
| 115 | std::vector<DoorIdentifier> malformed_doors; | 119 | std::vector<DoorIdentifier> malformed_doors; |
| 116 | }; | 120 | }; |
| 117 | 121 | ||
| 122 | struct DoorGroupInfo { | ||
| 123 | std::vector<HumanDoorGroup> definitions; | ||
| 124 | bool has_id = false; | ||
| 125 | |||
| 126 | std::vector<DoorIdentifier> malformed_doors; | ||
| 127 | }; | ||
| 128 | |||
| 118 | struct CollectedInfo { | 129 | struct CollectedInfo { |
| 119 | std::map<std::string, MapInfo> maps; | 130 | std::map<std::string, MapInfo> maps; |
| 120 | std::map<RoomIdentifier, RoomInfo, RoomIdentifierLess> rooms; | 131 | std::map<RoomIdentifier, RoomInfo, RoomIdentifierLess> rooms; |
| @@ -128,6 +139,7 @@ struct CollectedInfo { | |||
| 128 | std::map<std::string, EndingInfo> endings; | 139 | std::map<std::string, EndingInfo> endings; |
| 129 | std::map<std::string, PanelNameInfo> panel_names; | 140 | std::map<std::string, PanelNameInfo> panel_names; |
| 130 | std::map<std::string, ProgressiveInfo> progressives; | 141 | std::map<std::string, ProgressiveInfo> progressives; |
| 142 | std::map<std::string, DoorGroupInfo> door_groups; | ||
| 131 | }; | 143 | }; |
| 132 | 144 | ||
| 133 | } // namespace com::fourisland::lingo2_archipelago | 145 | } // namespace com::fourisland::lingo2_archipelago |
| diff --git a/tools/validator/validator.cpp b/tools/validator/validator.cpp index ab1612e..dd41f5c 100644 --- a/tools/validator/validator.cpp +++ b/tools/validator/validator.cpp | |||
| @@ -48,6 +48,9 @@ class Validator { | |||
| 48 | for (const auto& [prog_name, prog_info] : info_.progressives) { | 48 | for (const auto& [prog_name, prog_info] : info_.progressives) { |
| 49 | ValidateProgressive(prog_name, prog_info); | 49 | ValidateProgressive(prog_name, prog_info); |
| 50 | } | 50 | } |
| 51 | for (const auto& [group_name, group_info] : info_.door_groups) { | ||
| 52 | ValidateDoorGroup(group_name, group_info); | ||
| 53 | } | ||
| 51 | } | 54 | } |
| 52 | 55 | ||
| 53 | private: | 56 | private: |
| @@ -103,7 +106,8 @@ class Validator { | |||
| 103 | return false; | 106 | return false; |
| 104 | } | 107 | } |
| 105 | 108 | ||
| 106 | if (h_door.keyholders_size() > 0 || h_door.endings_size() > 0) { | 109 | if (h_door.keyholders_size() > 0 || h_door.endings_size() > 0 || |
| 110 | h_door.complete_at() > 0) { | ||
| 107 | return true; | 111 | return true; |
| 108 | } | 112 | } |
| 109 | 113 | ||
| @@ -173,6 +177,11 @@ class Validator { | |||
| 173 | std::cout << " PROGRESSIVE " << prog_name << std::endl; | 177 | std::cout << " PROGRESSIVE " << prog_name << std::endl; |
| 174 | } | 178 | } |
| 175 | 179 | ||
| 180 | for (const std::string& group_name : | ||
| 181 | door_info.door_groups_referenced_by) { | ||
| 182 | std::cout << " DOOR GROUP " << group_name << std::endl; | ||
| 183 | } | ||
| 184 | |||
| 176 | if (door_info.has_id) { | 185 | if (door_info.has_id) { |
| 177 | std::cout << " An AP ID is present." << std::endl; | 186 | std::cout << " An AP ID is present." << std::endl; |
| 178 | } | 187 | } |
| @@ -248,6 +257,22 @@ class Validator { | |||
| 248 | std::cout << "Port " << port_identifier.ShortDebugString() | 257 | std::cout << "Port " << port_identifier.ShortDebugString() |
| 249 | << " was defined multiple times." << std::endl; | 258 | << " was defined multiple times." << std::endl; |
| 250 | } | 259 | } |
| 260 | |||
| 261 | if (!port_info.target_connections_referenced_by.empty()) { | ||
| 262 | for (const HumanPort& port : port_info.definitions) { | ||
| 263 | if (port.has_required_door()) { | ||
| 264 | std::cout << "Port " << port_identifier.ShortDebugString() | ||
| 265 | << " has a required door but is the target of a connection:" | ||
| 266 | << std::endl; | ||
| 267 | |||
| 268 | for (const HumanConnection& connection : | ||
| 269 | port_info.target_connections_referenced_by) { | ||
| 270 | std::cout << " CONNECTION " << connection.ShortDebugString() | ||
| 271 | << std::endl; | ||
| 272 | } | ||
| 273 | } | ||
| 274 | } | ||
| 275 | } | ||
| 251 | } | 276 | } |
| 252 | 277 | ||
| 253 | void ValidatePainting(const PaintingIdentifier& painting_identifier, | 278 | void ValidatePainting(const PaintingIdentifier& painting_identifier, |
| @@ -271,6 +296,22 @@ class Validator { | |||
| 271 | std::cout << "Painting " << painting_identifier.ShortDebugString() | 296 | std::cout << "Painting " << painting_identifier.ShortDebugString() |
| 272 | << " was defined multiple times." << std::endl; | 297 | << " was defined multiple times." << std::endl; |
| 273 | } | 298 | } |
| 299 | |||
| 300 | if (!painting_info.target_connections_referenced_by.empty()) { | ||
| 301 | for (const HumanPainting& painting : painting_info.definitions) { | ||
| 302 | if (painting.has_required_door()) { | ||
| 303 | std::cout << "Painting " << painting_identifier.ShortDebugString() | ||
| 304 | << " has a required door but is the target of a connection:" | ||
| 305 | << std::endl; | ||
| 306 | |||
| 307 | for (const HumanConnection& connection : | ||
| 308 | painting_info.target_connections_referenced_by) { | ||
| 309 | std::cout << " CONNECTION " << connection.ShortDebugString() | ||
| 310 | << std::endl; | ||
| 311 | } | ||
| 312 | } | ||
| 313 | } | ||
| 314 | } | ||
| 274 | } | 315 | } |
| 275 | 316 | ||
| 276 | void ValidatePanel(const PanelIdentifier& panel_identifier, | 317 | void ValidatePanel(const PanelIdentifier& panel_identifier, |
| @@ -332,6 +373,22 @@ class Validator { | |||
| 332 | std::cout << "Panel " << panel_identifier.ShortDebugString() | 373 | std::cout << "Panel " << panel_identifier.ShortDebugString() |
| 333 | << " is missing an AP ID." << std::endl; | 374 | << " is missing an AP ID." << std::endl; |
| 334 | } | 375 | } |
| 376 | |||
| 377 | if (!panel_info.target_connections_referenced_by.empty()) { | ||
| 378 | for (const HumanPanel& panel : panel_info.definitions) { | ||
| 379 | if (panel.has_required_door()) { | ||
| 380 | std::cout << "Panel " << panel_identifier.ShortDebugString() | ||
| 381 | << " has a required door but is the target of a connection:" | ||
| 382 | << std::endl; | ||
| 383 | |||
| 384 | for (const HumanConnection& connection : | ||
| 385 | panel_info.target_connections_referenced_by) { | ||
| 386 | std::cout << " CONNECTION " << connection.ShortDebugString() | ||
| 387 | << std::endl; | ||
| 388 | } | ||
| 389 | } | ||
| 390 | } | ||
| 391 | } | ||
| 335 | } | 392 | } |
| 336 | 393 | ||
| 337 | void ValidateKeyholder(const KeyholderIdentifier& keyholder_identifier, | 394 | void ValidateKeyholder(const KeyholderIdentifier& keyholder_identifier, |
| @@ -460,6 +517,26 @@ class Validator { | |||
| 460 | } | 517 | } |
| 461 | } | 518 | } |
| 462 | 519 | ||
| 520 | void ValidateDoorGroup(const std::string& group_name, | ||
| 521 | const DoorGroupInfo& group_info) const { | ||
| 522 | if (group_info.definitions.empty()) { | ||
| 523 | std::cout << "Door group \"" << group_name | ||
| 524 | << "\" has no definition, but was referenced:" << std::endl; | ||
| 525 | |||
| 526 | if (group_info.has_id) { | ||
| 527 | std::cout << " An AP ID is present." << std::endl; | ||
| 528 | } | ||
| 529 | } else if (group_info.definitions.size() > 1) { | ||
| 530 | std::cout << "Door group \"" << group_name | ||
| 531 | << "\" has multiple definitions." << std::endl; | ||
| 532 | } | ||
| 533 | |||
| 534 | if (!group_info.has_id) { | ||
| 535 | std::cout << "Door group \"" << group_name << "\" is missing an AP ID." | ||
| 536 | << std::endl; | ||
| 537 | } | ||
| 538 | } | ||
| 539 | |||
| 463 | const CollectedInfo& info_; | 540 | const CollectedInfo& info_; |
| 464 | }; | 541 | }; |
| 465 | 542 | ||
