[Apworld] Fixed reqs simplification mutating common objects

1 files changed, 9 insertions, 4 deletions

@@ -114,15 +114,20 @@ class AccessRequirements:
             old_or_logic = self.or_logic
 
             def remove_redundant(sub_reqs: "AccessRequirements"):
-                sub_reqs.letters = {l: v for l, v in sub_reqs.letters.items() if self.letters.get(l, 0) < v}
+                new_reqs = sub_reqs.copy()
+                new_reqs.letters = {l: v for l, v in new_reqs.letters.items() if self.letters.get(l, 0) < v}
+                if new_reqs != sub_reqs:
+                    return new_reqs
+                else:
+                    return sub_reqs
 
             self.or_logic = []
             for disjunction in old_or_logic:
                 new_disjunction = []
                 for ssr in disjunction:
-                    remove_redundant(ssr)
-                    if not ssr.is_empty():
-                        new_disjunction.append(ssr)
+                    new_ssr = remove_redundant(ssr)
+                    if not new_ssr.is_empty():
+                        new_disjunction.append(new_ssr)
                     else:
                         new_disjunction.clear()
                         break