From 1d4b88e0bfe162419bf9466341ccec5f1e5656da Mon Sep 17 00:00:00 2001 From: Kelly Rauchenberger Date: Sun, 17 Dec 2017 14:44:38 -0500 Subject: Updated curlcpp (important bug fixes) This update fixes the underlying issue behind an infinite-stalling bug that has been around since differencebot was written. The four bots that download images from ImageNet (difference, advice, grunge, capital) had the same small logic error whereby the catch block, written to handle the situation when an image had failed to download, incorrectly took the exception by value rather than by const reference. While inefficient, this should not have caused any problems, but curlcpp, which the four bots all use through libtwitter++'s dependence on it, had a bug in the copy constructor of the curl_exception object which could cause a deadlock situation. This went unnoticed for a while, despite the four bots having serious downtime issues. When this was discovered, the bots were patched so that the relevant catch block took the exception by const reference. While this fixed things, it is also prudent to update curlcpp to the newest version in which this bug has been fixed. refs JosephP91/curlcpp#100 --- vendor/curlcpp | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/vendor/curlcpp b/vendor/curlcpp index 687be1c..11c4979 160000 --- a/vendor/curlcpp +++ b/vendor/curlcpp @@ -1 +1 @@ -Subproject commit 687be1c252dce098f488ca8a46d847dac4972310 +Subproject commit 11c4979d323f2e12a466bb768b66569e5f9a7ea3 -- cgit 1.4.1